Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asset search in nested subdirectories #7313

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Fix asset search in nested subdirectories #7313

merged 3 commits into from
Jan 6, 2023

Conversation

edalzell
Copy link
Contributor

@edalzell edalzell commented Jan 6, 2023

Closes #7312

@what-the-diff
Copy link

what-the-diff bot commented Jan 6, 2023 •
edited
Loading

  • Added a new test to ensure that searching for assets in subdirectories works.
  • Updated the route definition so it can handle paths with slashes (e.g., nested/subdirectory).

jasonvarga
jasonvarga approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@jasonvarga jasonvarga changed the title Asset search route needs where Fix asset search in nested subdirectories Jan 6, 2023
@jasonvarga jasonvarga merged commit 996a2fc into statamic:3.3 Jan 6, 2023
@edalzell edalzell deleted the fix/asset-browser-search-path branch January 6, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga jasonvarga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't search assets in asset browser stack in Runway
2 participants
@edalzell @jasonvarga