Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the ignore_query_string setting when handling nocache Sessions #7488

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Use the ignore_query_string setting when handling nocache Sessions #7488

merged 2 commits into from
Feb 8, 2023

Conversation

arthurperton
Copy link
Contributor

Fixes #7487.

@what-the-diff
Copy link

what-the-diff bot commented Feb 7, 2023

  • The query string is now ignored when the config option statamic.static_caching.ignore_query_strings is set to true
  • A new test was added for this feature

@jasonvarga jasonvarga merged commit 2956248 into statamic:3.4 Feb 8, 2023
@arthurperton arthurperton deleted the issue/7487-nocache-ignore-query-strings branch February 8, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonvarga jasonvarga Awaiting requested review from jasonvarga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The nocache tag shows blank content when ignore_query_strings is true
2 participants
@arthurperton @jasonvarga