Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insecure flag to skip ssl verification when warming static cache #8056

Merged
merged 4 commits into from
May 5, 2023

Conversation

o1y
Copy link
Contributor

@o1y o1y commented May 4, 2023

This PR adds an --insecure flag to the static:warm command to skip SSL verification. The --insecure option is useful to warm the static cache even when running Statamic with self-signed certs (e.g. behind a reverse proxy).

@what-the-diff
Copy link

what-the-diff bot commented May 4, 2023

PR Summary

  • Added a new option to skip SSL verification
    A new option has been introduced to allow the user to bypass SSL certificate checks.

  • Updated client configuration with the new option
    The client configuration has been updated to incorporate the new option for skipping SSL verification.

Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extract a method? Those stacking negatives are hard to grok.

"If not insecure and not local." 🤯

'verify' => $this->shouldVerifySsl(),

@o1y o1y requested a review from jasonvarga May 5, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants