Git integration #1954
Merged
Git integration #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for string based commands.
|
Oh @jackmcdade, just a reminder this guy needs a proper utility icon whenever you have time... |
This was referenced Jul 1, 2020
- Save method always dispatches event - Moving an asset will just save itself instead of using a dedicated event. - Remove Asset::replace(), it's never used. - Keep AssetUploaded event, but don't use it for Git. - Asset doesn't need a file uploaded in the Git tests. Explicitly test the upload case. - Adjust asset tests to handle save being called. (Check event is dispatched, fake the dimension cache disk, and use image method so an actual image is faked.)
# Conflicts: # resources/lang/fr.json # resources/lang/fr/messages.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving Spock functionality into v3 (will be a 'Pro' feature).
Closes statamic/ideas#199.