Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @collection directive #2128

Closed
wants to merge 5 commits into from
Closed

Add @collection directive #2128

wants to merge 5 commits into from

Conversation

edalzell
Copy link
Contributor

Implements statamic/ideas#212

@jasonvarga
Copy link
Member

This is a nice start 🎉 but what about parameters?

@edalzell
Copy link
Contributor Author

What about ‘em?

@jasonvarga
Copy link
Member

As it stands you can just get all the entries. What about limiting, filtering, pagination?

@edalzell
Copy link
Contributor Author

Oh you want FAAAANCY stuff.

@edalzell
Copy link
Contributor Author

@jasonvarga any ideas how you parse parameters passed into custom directives? They come in as a string.

@jasonvarga
Copy link
Member

No but I imagine you can look at some of the native Laravel Blade directives, like @include that allow arguments.

@edalzell
Copy link
Contributor Author

done @jasonvarga. Didn't do pagination as it returns something different and I didn't want to deal with it now.

@jasonvarga
Copy link
Member

This is great Erin, thank you for the PR. However I don't think this is quite what we'd want in the core in it's current state. You should be able to plop all of this in an addon very easily though.

@jasonvarga jasonvarga closed this Aug 3, 2020
@edalzell edalzell deleted the blade-directives branch August 6, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants