Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check origin if a value is empty for a searchable #2789

Closed
wants to merge 2 commits into from

Conversation

riasvdv
Copy link
Contributor

@riasvdv riasvdv commented Nov 2, 2020

Translated items often have NULL as a value, but in the search index you want the origin's value included, this adds that value

Translated items often have `NULL` as a value, but in the search index you want the origin's value included, this adds that value
@jasonvarga
Copy link
Member

A better solution is changing the get() on the line above to value(). If you do that, does it work for you?

@riasvdv
Copy link
Contributor Author

riasvdv commented Nov 3, 2020

That works! Changed the PR to that implementation

@jasonvarga jasonvarga closed this in 88b245b Nov 5, 2020
@jasonvarga
Copy link
Member

It ended up not quite being that simple because not all items would have a value method. I've implemented the feature for you anyway.

@riasvdv riasvdv deleted the patch-3 branch November 6, 2020 05:28
@riasvdv
Copy link
Contributor Author

riasvdv commented Nov 6, 2020

👏 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants