Fix Replicator/Grid/Bard not displaying newly added items after saving #7000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6993
The reported issue was about Replicator, but it also happened in Bard and Grid.
Previously, we would use ids to keep track of reordering etc just in JS, and throw the IDs away when you save just so you wouldn't get them in your data.
Now that we update the form with fresh values since #6842, the fieldtype preprocessing would assign new IDs, the JS would get confused, and the newly added items would mismatch, cause a JS error, and not display.
There would be no data loss, it would just look like it.
This PR will keep the IDs in the data/yaml. It's the simplest solution we could find, and there's no harm to having
id
keys in there.Todo:
id
at the top of the array. It's just a little nicer, it's awkward at the end especially if there are nested arrays.