Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows localization variable to be saved as false. #7087

Merged
merged 3 commits into from Nov 30, 2022
Merged

Allows localization variable to be saved as false. #7087

merged 3 commits into from Nov 30, 2022

Commits on Nov 19, 2022

  1. Allows localization variable to be saved as false.

    The localisation variable is always reset as true when updating blueprints. If you have a field that is not localizable and update the blueprint for any reason, the field is sent in the PATCH request with `localizable: false` which is then unset by this code. This means if the field has been localizable before then it can't be changed to non-localizable... which causes an issue as slugs are default localizable even when multisite is not enabled.
    
    This code checks if multisite is enabled, and prevents the field from being unset. This fixes #7082, #4471 and continues to allow the localizable field to be unset on single sites so that the blueprints remain unaffected. On multi-sites, the blueprints will be updated the next time they are saved, and will explicitly say if fields are localizable or not by adding `localizable: false` to each one.
    tao committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    45c5d17 View commit details
    Browse the repository at this point in the history
  2. Update FieldTransformer.php

    tao committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    79dc23b View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Simplify

    jasonvarga committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    e62f3d8 View commit details
    Browse the repository at this point in the history