PHP 8.2 #7299
Merged
PHP 8.2 #7299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
… ever needed this param.)
… 8.2 anymore. Indead we'll add 10000 to non-preferred index, since nobody should ever have 10k columns.
…precation warning
…. You cant pass null to Str::startsWith
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds PHP 8.2 support.
There were only a few little issues. The main one was that carbon needed to be updated to a version that supported 8.2. laravel/framework#44374
Everything else was really just concerning deprecation warnings. The majority was due to missing properties.
Running PHPUnit with
convertDeprecationsToExceptions="true"now completely passes except for one test.The failing test is due to a deprecation warning within
webonyx/graphql-php. I tried PRing a tiny fix but it was rejected. Oh well. webonyx/graphql-php#1280I tried upgrading
laravel-graphqlto the next version just to test it (which uses v15 of graphql-php) and makes everything pass again, without any code changes on our side. It's not released yet, though. rebing/graphql-laravel#953