Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve image validation when manipulating images #7666

Merged
merged 26 commits into from
Mar 17, 2023
Merged

Fix and improve image validation when manipulating images #7666

merged 26 commits into from
Mar 17, 2023

Commits on Mar 7, 2023

  1. Avoid processing svg's and pdf's on upload, because imagick will mang… 

    …le those.
    @jesseleite
    jesseleite committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    d45f7fa View commit details
    Browse the repository at this point in the history

  2. Copy functionality from #7652 and move allowedFileFormats() out of … 

    …tag class.
    @jesseleite
    jesseleite committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    05f8d9e View commit details
    Browse the repository at this point in the history

  3. Refactor uploader to check allowedFileFormats().

    @jesseleite
    jesseleite committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    206f43e View commit details
    Browse the repository at this point in the history

  4. Tweak config.

    @jesseleite
    jesseleite committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    cf9c696 View commit details
    Browse the repository at this point in the history

  5. Test that svg’s and pdf’s are also not processed.

    @jesseleite
    jesseleite committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    e29b481 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Change config to additional_extensions.

    @jesseleite
    jesseleite committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    a17e2c1 View commit details
    Browse the repository at this point in the history

  2. Refactor to isAllowedExtension() and handle lowercasing before comp… 

    …aring.
    @jesseleite
    jesseleite committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    f934e9d View commit details
    Browse the repository at this point in the history

  3. Test that it can process custom configured image extensions.

    @jesseleite
    jesseleite committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    f1c686a View commit details
    Browse the repository at this point in the history

  4. Data providers need to be public for some versions.

    @jesseleite
    jesseleite committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    2b3f6ae View commit details
    Browse the repository at this point in the history

  5. Meant this to be pdf.

    @jesseleite
    jesseleite committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    5425057 View commit details
    Browse the repository at this point in the history

  6. Pass failing tests.

    @jesseleite
    jesseleite committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    2e4a2eb View commit details
    Browse the repository at this point in the history

  7. Pass failing tests for real?

    @jesseleite
    jesseleite committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    9d4a4e5 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Improve mime type validation.

    @jesseleite
    jesseleite committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    2c40d72 View commit details
    Browse the repository at this point in the history

  2. Check mime type here too.

    @jesseleite
    jesseleite committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    49b8b42 View commit details
    Browse the repository at this point in the history

  3. Extract validation logic to more testable Imaging\Validator class.

    @jesseleite
    jesseleite committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    dcc5685 View commit details
    Browse the repository at this point in the history

  4. Pass tests again.

    @jesseleite
    jesseleite committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    8252641 View commit details
    Browse the repository at this point in the history

  5. Rename to ImageValidator.

    @jesseleite
    jesseleite committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    748f441 View commit details
    Browse the repository at this point in the history

  6. Add test coverage for ImageValidator.

    @jesseleite
    jesseleite committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    18f50bc View commit details
    Browse the repository at this point in the history

  7. Flesh out mime type tests a bit more.

    @jesseleite
    jesseleite committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    e5fe85a View commit details
    Browse the repository at this point in the history

  8. Test that validator gets called when generating.

    @jesseleite
    jesseleite committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    67a2995 View commit details
    Browse the repository at this point in the history

  9. Pass test again.

    @jesseleite
    jesseleite committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    46bbc9a View commit details
    Browse the repository at this point in the history

  10. Tweak method names.

    @jesseleite
    jesseleite committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    8177fe1 View commit details
    Browse the repository at this point in the history

  11. Check that ImageValidator is being run when processing uploads.

    @jesseleite
    jesseleite committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    4f2e75c View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. make private

    @jasonvarga
    jasonvarga committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    60fd5eb View commit details
    Browse the repository at this point in the history

  2. Merge branch '3.4' into fix/processing-source-images-with-svgs

    @jasonvarga
    jasonvarga committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    b93343c View commit details
    Browse the repository at this point in the history

  3. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    3bce8ae View commit details
    Browse the repository at this point in the history