[4.x] Refine collection visibility for multi-site setups #9583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjusted logic in CollectionsController and CoreNav to ensure users see relevant collections based on their permissions and the selected site.
pdipatrizio
force-pushed
the
fix/collection-multisite-ux
branch
from
574ba52
to
027993e
Compare
|
this would be a great and welcome addition |
But instead of them going to a page with an error, they'll go to the collection's edit/configure page.
…ly in other sites in CP nav
duncanmcclean
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Thank you for this PR! 🎉
After some discussion internally, we've made a couple of changes to this PR:
- When the logged in user has the "configure collections" permission, clicking into a collection not available in the selected site will take you to the collection's configure page, rather than the collections index page.
- This mirrors the behaviour we have for Global Sets at the moment.
- We've copied across the same changes to Navigations & Global Sets so they all behave in a similar fashion.
jasonvarga
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts logic in CollectionsController and CoreNav to ensure users see relevant collections based on their permissions and the selected site, because displaying collections to users who cannot do anything with them results in a confusing user experience.
Fixes #9319.
Example scenario:
Sites
Default
French
Collections
Pages (configured for Default and French)
Articles (configured for Default only)
While the French site is selected...
Previous behavior: The Articles collection is displayed in the collection index and nav, but clicking on it results in an error
Collection is not available on site "French".New behavior: The Articles collection is not displayed in the collection index and nav unless the user has permission to configure collections, in which case it is displayed so they may still access the configuration screen.