Skip to content
This repository has been archived by the owner on May 9, 2023. It is now read-only.

Errors when using cmd-enter keyboard shortcut #1009

Closed
than opened this issue Sep 30, 2016 · 15 comments
Closed

Errors when using cmd-enter keyboard shortcut #1009

than opened this issue Sep 30, 2016 · 15 comments

Comments

@than
Copy link

than commented Sep 30, 2016

Expected behaviour

Create a new entry. (Has happened on both taxonomies and entries).

Press cmd-Return to save the entry and return to the collection page.

Actual behaviour

In Safari - Statamic saves the entry, but it throws a js error.

screen shot 2016-09-30 at 11 01 41 am

I've also seen some cache corruption occur, where the entry will appear twice in the CP.

screen shot 2016-09-30 at 11 07 45 am

In Chrome, saving a taxonomy, the taxonomy collection would not display.

screen shot 2016-09-30 at 10 56 50 am

Steps to reproduce

  1. Create a new entry.
  2. Save the entry by pressing cmd-return.

Server configuration

Web server:
local dev with Valet

PHP version:
7

Statamic version:
2.1.12

Logs

If any logs (browser, server, or Statamic) are appropriate...

Add those logs here
@jackmcdade
Copy link
Member

Got any logs? I can't recreate this.

@than
Copy link
Author

than commented Sep 30, 2016

Doesn't seem to be throwing any logs... 😕

@jackmcdade
Copy link
Member

Sounds like file permissions to me then. Try to sudo chmod -R 777 site local statamic and try again.

@than
Copy link
Author

than commented Sep 30, 2016

Negative, ghost rider. All 777 all the time. Might have a hint here...

@jackmcdade
Copy link
Member

What's the hint?

@than
Copy link
Author

than commented Sep 30, 2016

Looks like the publish endpoint is being called twice?

screen shot 2016-09-30 at 11 12 16 am

@jasonvarga
Copy link
Member

I get that popup if I try to navigate away from the page while the AJAX request is going. Probably the same thing here.

@than
Copy link
Author

than commented Sep 30, 2016

So CP isn't waiting for the request to finish?

@than
Copy link
Author

than commented Sep 30, 2016

Feels like a race condition, since it isn't 100% of the time reproducible for me.

@jasonvarga
Copy link
Member

Does stuff work if you click save instead?

@than
Copy link
Author

than commented Sep 30, 2016

Yessir.

But the tax of moving my hand from the keyboard to the mouse is too heavy. 😆

@than
Copy link
Author

than commented Sep 30, 2016

BTW, cmd-S for saving in place is working just fine.

@jasonvarga
Copy link
Member

Happens to me in IE Safari.

@than
Copy link
Author

than commented Sep 30, 2016

I was able to do something similar in Chrome, too. see above.

@than
Copy link
Author

than commented Sep 30, 2016

One other side effect... I end with with the phantom entries if I don't clear:cache and then a request to Delete all of those entries fails.

screen shot 2016-09-30 at 11 36 58 am

screen shot 2016-09-30 at 11 38 02 am

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants