nav:breadcrumbs are broken when using routes

[mwesten]

Expected behaviour

Display the breadcrums for the URL-parts that are actual pages.

Actual behaviour

Breadcrumbs are shown for all URL-parts even if the pages don't exist (as in routing or vanity urls).

Steps to reproduce

Install Statamic 2.1.18 (in my case on http://breadcrumbs.dev )
Add the following to /sites/themes/redwood/layouts/default.html

{{ nav:breadcrumbs }}
  {{ title }} - 
{{ /nav:breadcrumbs }}

Now go to the following URLs:
http://breadcrumbs.dev/about This looks like it should

http://breadcrumbs.dev/blog This looks like it should too

Now go to to http://breadcrumbs.dev/blog/tags/harry-potter

or http://breadcrumbs.dev/blog/2015/07/22/fire-fire-looking-forward-to-hearing-from-you

it shows Home for all routed paths that aren't actual pages

Server configuration

Operating system: OSX 10.11.6

Web server: Apache 2.4.18

PHP version: 7.0.4

Statamic version: 2.1.18

Updated from an older Statamic or fresh install: Fresh Install

List of installed addons: none

[mwesten]

Hmmmm digging into it, it seems that code is there that should fix this (/statamic/bundles/Nav/NavTags.php line 128 and further).

Looking into it, the check that is done, tries to lookup the url and fetch the respective object containing data. The problem in the current situation is that the $default_segment_uri of the non-existent URL-parts are NULL values and fetching the Content of a NULL item returns an object, so all URL-parts are rendered as bredcrumbs.

Changing the code to this however checks if the $default_segment_uri is_null() and if it does, skips over it. This seems to do the trick !

[jasonvarga]

Thanks @mwesten !

[mwesten]

np ;) hope this works under all circumstances... just tested a couple of scenarios, but seems to hold up...