Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI errors on linting #71

Closed
kerzhner opened this issue Sep 5, 2022 · 1 comment · Fixed by #72
Closed

CI errors on linting #71

kerzhner opened this issue Sep 5, 2022 · 1 comment · Fixed by #72

Comments

@kerzhner
Copy link
Contributor

kerzhner commented Sep 5, 2022

https://github.com/statechannels/go-nitro-testground/runs/8186378977?check_suite_focus=true

Potentially related to golangci/golangci-lint#3107
@lalexgap lalexgap mentioned this issue Sep 5, 2022
Merged
@lalexgap
Copy link
Contributor

lalexgap commented Sep 5, 2022

I believe this is due to CI using go 1.19 (since we use a version range) and the version of golangci-lint we're using on ci (v1.45.2) not properly supporting go 1.19.

I think this can be resolved by upgrading to a later version of golangci-lint like we did in go-nitro

@lalexgap lalexgap closed this as completed Sep 5, 2022
@lalexgap lalexgap reopened this Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to go 1.19 statechannels/go-nitro-testground
2 participants
@kerzhner @lalexgap