Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When exiting, there is no way to ensure that all metrics were sent. #15

Closed
lopesmcc opened this issue Jun 30, 2017 · 0 comments
Closed

When exiting, there is no way to ensure that all metrics were sent. #15

lopesmcc opened this issue Jun 30, 2017 · 0 comments

Comments

@lopesmcc
Copy link

lopesmcc commented Jun 30, 2017 •
edited
Loading

flush is not exposed and close only closes the socket. This means that when exiting, buffered metrics might not be sent.

My proposal is to expose flush and also flush when close is invoked.

I might prepare a PR for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miguelcnf @lopesmcc