New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client Improvements #4

Open

mistic opened this issue Aug 22, 2016 · 1 comment

Labels

Contributor

mistic commented Aug 22, 2016

There are some improvements we need to do on the client:

Make validator to not allow that flushInterval < timeout.
Tests for system stats, blocked, and default config values.
Verify merge order between global, global defaults and method parameters.
Add start e stop methods to the client. The stop method should assure that all metrics in buffer are sent before client closes.
Create a constants file.
Remove close from prototype.
Move some helper request functions into a request class.

Contributor

senzzzi commented May 16, 2017

"Tests for system stats" are done when branch fix-systemstats-metrics is merged.

jmtavares added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment