You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the legacy (bravo2) variant page, there was a prop provided to the top level vue component for the number of samples in the underlying data set. This n_samples was hardcoded in the flask template that was generating and serving out the enclosing page html.
Hard coding :total-samples="132345" means the number of samples in the data set needs to be known by the UI at coding time. The current workaround moves this to the .env file so it only needs to be known at build time.
Desired State
An way for the API to answer the question, "how many samples are in the underlying data set?".
This could be a separate endpoint or as part of the existing endpoints. Specifically the variant endpoint would need it to be included if this were the case.
Problem
In the legacy (bravo2) variant page, there was a prop provided to the top level vue component for the number of samples in the underlying data set. This
n_samples
was hardcoded in the flask template that was generating and serving out the enclosing page html.Hard coding
:total-samples="132345"
means the number of samples in the data set needs to be known by the UI at coding time. The current workaround moves this to the .env file so it only needs to be known at build time.Desired State
An way for the API to answer the question, "how many samples are in the underlying data set?".
This could be a separate endpoint or as part of the existing endpoints. Specifically the variant endpoint would need it to be included if this were the case.
In any event, this issue is blocked until it is solved in https://github.com/statgen/bravo_api
The text was updated successfully, but these errors were encountered: