Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of samples in underlying data is hard coded #4

Open
grosscol opened this issue Dec 2, 2021 · 0 comments
Open

Number of samples in underlying data is hard coded #4

grosscol opened this issue Dec 2, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@grosscol
Copy link
Collaborator

grosscol commented Dec 2, 2021

Problem

In the legacy (bravo2) variant page, there was a prop provided to the top level vue component for the number of samples in the underlying data set. This n_samples was hardcoded in the flask template that was generating and serving out the enclosing page html.

<bravovariant :homepage="'{{ url_for('.home', _external = True) }}'" 
:api="'{{ url_for('.home', _external = True) }}'" 
:variant-id="'{{ variant_id }}'" 
:total-samples="132345" />

Hard coding :total-samples="132345" means the number of samples in the data set needs to be known by the UI at coding time. The current workaround moves this to the .env file so it only needs to be known at build time.

Desired State

An way for the API to answer the question, "how many samples are in the underlying data set?".
This could be a separate endpoint or as part of the existing endpoints. Specifically the variant endpoint would need it to be included if this were the case.

In any event, this issue is blocked until it is solved in https://github.com/statgen/bravo_api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant