Move health endpoint-related code into a separate file #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first step towards #342. At this point HealthHandler merely encapsulates static methods. The idea is to have init() method also handle moving Settings::General::health to RequestHandlerOpts::health in future. Ideally, handling of the health setting CLI and config file will be added here as well (not trivial given how parsing is tied to data structures).
|
Review changes with SemanticDiff. Analyzed 4 of 4 files. Overall, the semantic diff is 17% smaller than the GitHub diff.
|
…eded in future either
13 tasks
joseluisq
changed the title
joseluisq
changed the title
joseluisq
changed the title
joseluisq
requested changes
Apr 16, 2024
joseluisq
added
enhancement
joseluisq
pushed a commit
that referenced
this pull request
Apr 18, 2024
This is largely analogous to #344, another step towards fixing #342. Loading logger module in lib.rs was moved up for sake of consistency: modules loaded after it will have macros like server_info imported implicitly, the ones loaded before won't. Further alphabetical rearranging of modules was performed by rustftm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This creates a new module
healthresponsible for the health endpoint. So far it handles the server initialization in theinit()method and request processing in thepre_process()method. Ideally, handling of the health setting in CLI and config file will also be added here in future (not trivial given how parsing is tied to data structures).Related Issue
This is a tiny first step towards #342.
How Has This Been Tested?
Tests pass, and I’ve added a few new tests as well. I did not perform any functional testing at this point.