Move metrics endpoint-related code into a separate file #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is largely analogous to #344, another step towards fixing #342. Loading logger module in lib.rs was moved up for sake of consistency: modules loaded after it will have macros like server_info imported implicitly, the ones loaded before won't. Further alphabetical rearranging of modules was performed by rustftm.
|
Review changes with SemanticDiff. Analyzed 5 of 5 files.
|
13 tasks
joseluisq
added
enhancement
joseluisq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is largely analogous to #344.
Loading logger module in lib.rs was moved up for sake of consistency: modules loaded after it will have macros like
server_infoimported implicitly, the ones loaded before won't. Further alphabetical rearranging of modules was performed by rustfmt.Related Issue
This is another step towards fixing #342.
How Has This Been Tested?
Tests pass, and I’ve added a few new tests as well. Functional testing on Linux didn’t show any issues.