Move all of Basic authentication logic into basic_auth module #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 4 of 4 files. Overall, the semantic diff is 3% smaller than the GitHub diff.
|
13 tasks
joseluisq
added
enhancement
joseluisq
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This establishes the same internal API for the
basic_authmodule as forhealthandmetricsmodules, the logic is now mostly self-contained in the module. While I hoped to avoid merge conflicts, there will be at least one merge conflict with #345 (importingserver_infoinbasic_auth.rswill no longer be necessary).Related Issue
This is another step towards fixing #342.
How Has This Been Tested?
Tests have been extended, so all the relevant scenarios should be tested automatically now. Functional testing on Linux didn’t show any issues.