Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new analysis subtypes #55

Closed
bradfordcondon opened this issue Dec 19, 2017 · 7 comments
Closed

Create new analysis subtypes #55

bradfordcondon opened this issue Dec 19, 2017 · 7 comments
Labels
Core-related Tripal core's responsibility

Comments

@bradfordcondon
Copy link
Contributor

Every analysis that requires custom fields needs a subtype.

tripal/tripal#224

@bradfordcondon
Copy link
Contributor Author

term for transcriptome assembly (previously analysis_unigene): operation:3258

genome assembly: previously .... ? vanilla analysis : operation:0525

@bradfordcondon
Copy link
Contributor Author

Problem with defining analysis unigene type:

the module did not utilize the analysis_type prop.

so we either a) have our unigene type depend on something else (ie analysis_unigene_name, which is what the module uses as the identifeir)….. buuuuut defining the type we say the prop is equal to something, not taht the prop exists

or b) insert the prop into all of our analysis unigene analyses

@bradfordcondon
Copy link
Contributor Author

this update should work to make our existing unigene analyses have hte correct analysis type prop set

tripal/tripal_analysis_unigene#2

@bradfordcondon bradfordcondon added the Core-related Tripal core's responsibility label Dec 22, 2017
@bradfordcondon
Copy link
Contributor Author

This task is addressed by this "module" which we only want for the install script.

https://github.com/bradfordcondon/tripal_manage_analyses

Normally we would just re-migrate the analyses, but since we've put a lot of work into manually re-adding node fields, we don't want to do that here.

This module will properly tag unigene analyses as transcriptomes or genomes based on their associated features, then migrate the entities from the plain analysis to the new type. It's not finished: something is wrong with my update query to the tripal_entity table.

If this is something we would want to regularly do , then the module could be built up to be more general converting one entity type to another based on some criterion.

@bradfordcondon
Copy link
Contributor Author

Migrated for transcriptomes.

Genomes

Oops, these were analyses not analysis unigenes.
Let's manually set the analysis_type prop of these 8 genomes to genome_assembly and write an update that will just mirgate those entities
Prop updated for:

  • Fraxinus excelsior 08-02-16
  • Genome analysis Valley oak (Quercus lobata)
  • de novo English Walnut (Juglans regia)
  • Whole Genome Assembly and Annotation of Citrus Sinensis (JGI)
  • Chinese Chestnut Analysis
  • Chinese Chestnut Disease Resistant QTL Regions Analysis

@bradfordcondon
Copy link
Contributor Author

Created and populated!

@bradfordcondon
Copy link
Contributor Author

Note: We still need types for blast and interproscan annotation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core-related Tripal core's responsibility
Projects
None yet
Development

No branches or pull requests

1 participant