Accessing unexisting parser.Players

[romain-durban]

DP/GameEventHandler.cs ~line 140 (event "player_disconnect")
Got out of index exception on parser.Players[(int)data["userid"]].Disconnected = true;, fixed by making sure the index is valid: if(parser.Players.ContainsKey ((int)data ["userid"]))

[moritzuehling]

This should not happen - if a player disconnects he should be there in the first place. Is it possible to send the demo to github@moritzuehling.de?

Thanks!

[romain-durban]

I think it happens because of bots joining the game before the demo starts (Matchmaking) and then do not produce connection event in the parser. The error indeed occurs on a bot being kicked by console.
I'll send the demo, but this should actually happen for all MM demos downloaded from the server.

Since this check is done only on 'disconnect' events, it's not really expensive, all the more it's a dictionary key check.

[moritzuehling]

Since this check is done only on 'disconnect' events, it's not really expensive, all the more it's a dictionary key check.

Hey,

our main goal is that the check is not necessary because in fact, it shouldn't be. So I rather fix the missing player than fixing the symptom.

[moritzuehling]

This issue should be fixed in e560b2b.

Much thanks for you help, @romain-durban !