Skip to content
This repository has been archived by the owner on Mar 1, 2019. It is now read-only.

Refactor python script #4

Merged
merged 3 commits into from
Dec 27, 2018
Merged

Refactor python script #4

merged 3 commits into from
Dec 27, 2018

Conversation

ChihChengLiang
Copy link
Contributor

No description provided.

@ChihChengLiang ChihChengLiang mentioned this pull request Dec 20, 2018
Merged
mratsim
mratsim approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@mratsim mratsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I preferred to have the generator self-contained in a file for a quick starter, but I guess we would have lots of redundancy in that case (hash function for example).

@mratsim mratsim merged commit d77b8b2 into status-im:master Dec 27, 2018
@ChihChengLiang ChihChengLiang deleted the prettify-python-script branch December 27, 2018 14:09
@ChihChengLiang ChihChengLiang mentioned this pull request Dec 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mratsim mratsim mratsim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChihChengLiang @mratsim