-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add boot hosts #1
Conversation
Ansible issue
Solved by:
|
Current issues:
|
SSH keys setup:
|
For DO we can do it: For AC, looks like one key allowed only: As an alternative:
Proper solution was to change ansible role locally. |
It's failing with following in the logs:
Need to investigate the logic: |
|
New issues:
|
|
Looks like |
Other issues
|
Unfornutely it doesn't fail the installation. |
This code fails to detect One of the issues:
Note (deleted) in the end. Probably restart should help. Second is probably in installer code itself - |
I don't know, why it is even looks at this file, here is wakuv2.shards for example:
Looks like they reverence the cloud specific repo mirrors. |
I don't get your issue with Netdata, the
Seems like something else is at play. Maybe just an upgrade will help, not sure tho. |
Also, it seems like now Netdata has its own ubuntu repository we could use:
So maybe the best thing would be to ditch the shitty installer and just use their repo. Although one disadvantage of that is that pinning a version is harder. But it does appear they provide multiple versions. |
I think they don't import |
I added debug and I can see some messages like: So probably this code will not work as intended in some cases, when lock file doesn't exist (yet?): |
Command to reproduce:
Fix:
Follow-up: |
Alibaba Cloud images:
Looks ok, although old hosts needs to be upgraded to |
More on the netdata installation:
They even have a community supported playbook: The most popular role from Galaxy: Why they are so obsessed with installer scripts? |
Reproduced:
Workaround: |
Which is weird, because Ansible runs ssh with |
Sometimes I see the issue, which is not failing Ansible:
|
Didn't reproduce the
Need to double check with recreation of instance.
No |
Caught the
So it's |
Caught again:
|
Reproduce:
Maybe we need to wait a bit for instance fully available via ssh. Workaround: |
I think you are really overthinking this. The sleep in the first task in bootstrap is there for a reason. I think you should stop trying to fix alibaba nonsense locking for now. Is probably just because their bootstrap doesn't finish because the instance you're using is too slow. |
Also, I would recommend keeping research like this in the issue, and not in the PR. |
Yeah, I stoped investigating the non-blocking issues as we agreed yesterday. |
Reproduced on the 2nd run after instance created:
Rerun didn't help. Need to add keys to admin user: |
I will create proper Issues afterwards as a follow-up. |
Will revert to |
|
Disabled the role, but probably it will fire up later |
9d776c6
to
a7d9094
Compare
Removed loop_control as a workaround |
a7d9094
to
9c45c37
Compare
Load is skipped wrongly, because generation is skipped. |
to debug / catch the lock issues, I was adding:
before Also, I think |
9c45c37
to
79077eb
Compare
Potential temporary workaround for netdata: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would split this up into separate PRs, partially because you filled this PR with comments that are research/debug comments, and partially because you are doing a LOT in one commit. I'd say PRs are for discussing the changes when reviewing, and issues are for your own research and debugging. That way a person that wants to review a PR doesn't get greeted by a wall of text of 40+ comments that have no relevance to their review.
My recommendation would be:
- Remove commented out stuff unless it actually is relevant to future work needed.
- Separate out general terraform changes into one commit, like secrets setup or provider setup.
- Separate out into another commit the creation of the fleet and its emergency inventory.
- Separate out the Ansible playbook and group variable changes.
Also, I would start without any bootstrap__active_extra_users
, and grant them on case-by-case basis as they request it. Unless you were already told to grant the same access as from some other fleet.
This PR is closed in a favour of these 3 as requested by @jakubgs: The following issues were discovered during the work on this PR:
|
No description provided.