Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official operations - deposits unit test #408

Merged
merged 10 commits into from
Sep 11, 2019
Merged

Conversation

mratsim
Copy link
Contributor

@mratsim mratsim commented Sep 8, 2019

For now:

  • deposits block. This required ignoring invalid signatures in deposits (previously we asserted they were valid)

some tests deactivated due to #407 (skipValidation flag too strong so we don't trigger assertion when passed something that the spec expect to fail)

@mratsim
Copy link
Contributor Author

mratsim commented Sep 8, 2019

Deposits CI:

[Suite] Official - Operations - Deposits  [Preset: minimal]
    Unhandled exception: The parameter is incorrect.
 [OSError]
  [FAILED] [Valid]   new deposit under max (new_deposit_under_max)
    Unhandled exception: The parameter is incorrect.
 [OSError]
  [FAILED] [Valid]   new deposit max (new_deposit_max)
    Unhandled exception: The parameter is incorrect.
 [OSError]
  [FAILED] [Valid]   new deposit over max (new_deposit_over_max)
    Unhandled exception: The parameter is incorrect.
 [OSError]
  [FAILED] [Valid]   invalid signature new deposit (invalid_sig_new_deposit)
    Unhandled exception: The parameter is incorrect.
 [OSError]
  [FAILED] [Valid]   success top-up (success_top_up)
    Unhandled exception: The parameter is incorrect.
 [OSError]
  [FAILED] [Valid]   invalid signature top-up (invalid_sig_top_up)
    Unhandled exception: The parameter is incorrect.
 [OSError]
  [FAILED] [Valid]   invalid withdrawal credentials top-up (invalid_withdrawal_credentials_top_up)

@mratsim
Copy link
Contributor Author

mratsim commented Sep 8, 2019

Note that Appveyor CI without -d:release is crazy slow, x86 (32-bit) has been running for almost 40 min at the moment.

@mratsim mratsim changed the title Official operations unit test Official operations - deposits unit test Sep 8, 2019
@mratsim
Copy link
Contributor Author

mratsim commented Sep 9, 2019

The CI fails on -d:release on windows 64-bit (and works on 32-bit).

It seems like the error thrown "The parameter is incorrect" seems to be thrown by windows and reraised with raiseOSerror(osLastError())

@tersec
Copy link
Contributor

tersec commented Sep 11, 2019

I'd be happy to merge this with something akin to #438 included either as part of the initial merge or after the fact.

@mratsim
Copy link
Contributor Author

mratsim commented Sep 11, 2019

let's merge it

@tersec tersec merged commit 988a13b into master Sep 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the Official-operations-unit-test branch September 11, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants