[Tests] Refine skipValidation flag #407
Comments
mratsim
added a commit
that referenced
this issue
Sep 9, 2019
mratsim
added a commit
that referenced
this issue
Sep 9, 2019
* Block headers tests * Skip invalid_parent_root test due to #407 * Fix bls_verify with invalid sig. Activate block header tests
Merged
zah
pushed a commit
that referenced
this issue
Jan 7, 2020
Note: this does more than just disable bls - see #407, so is not strictly consistent with other `beacon-fuzz` implementations.
zah
pushed a commit
that referenced
this issue
Jan 7, 2020
Note: this does more than just disable bls - see #407, so is not strictly consistent with other `beacon-fuzz` implementations.
zah
pushed a commit
that referenced
this issue
Jan 8, 2020
Note: this does more than just disable bls - see #407, so is not strictly consistent with other `beacon-fuzz` implementations.
This was referenced Jan 13, 2020
Closed
This was referenced Feb 5, 2020
|
I think this is resolved by #735? |
|
Along with other changes since which don't require as many special cases/opt-outs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
skipValidationflag is too coarse and should at least propose a skipBLSValidation option that does not skipverifyStateRoot.This impacts the test suite as some tests use invalid signatures but expect failures on verifyStateRoot
The text was updated successfully, but these errors were encountered: