-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(issue-1052): Single topic for RPC Message #1061
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1061 +/- ##
============================================
- Coverage 82.81% 82.52% -0.30%
============================================
Files 91 91
Lines 15750 15820 +70
============================================
+ Hits 13043 13055 +12
- Misses 2707 2765 +58
|
one thing missing here is that the code must check that there is (at least) one topic when decoding the message from bytes |
4e01b37
to
ed5d9d4
Compare
ed5d9d4
to
cb5bd9a
Compare
What's the expected behaviour if there isn't? |
penalize the peer for sending an invalid message (same as if signature was bad or it wasn't protobuf at all) |
6eec9db
to
1441e2f
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Rename RPC's Message
topicIds
totopicId
.Please, do look carefully into this one as I'm not sure how a well covered by tests is the repo, and my changes could be breaking stuff.
Issue
Closes (hopefully): #1052