-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved logging/docs for validator flow #3699
Comments
The |
@arnetheduck ah good to know! I guess this is my fault, I was trying to read the Joe Clapis guide which lead me to an older version of his repo https://github.com/jclapis/rp-pi-guide/blob/main/Grafana.md. I can't find any references to |
Since these files may have been created in a previous run or manually, we want to keep loading them even on nodes that don't enable the keystore API (for example static setups) * log keystore loading progressively (#3699)
Since these files may have been created in a previous run or manually, we want to keep loading them even on nodes that don't enable the keystore API (for example static setups) * log keystore loading progressively (#3699)
Since these files may have been created in a previous run or manually, we want to keep loading them even on nodes that don't enable the keystore API (for example static setups) * log keystore loading progressively (#3699)
Since these files may have been created in a previous run or manually, we want to keep loading them even on nodes that don't enable the keystore API (for example static setups) * log keystore loading progressively (#3699)
…4078) Since these files may have been created in a previous run or manually, we want to keep loading them even on nodes that don't enable the keystore API (for example static setups) Other changes: * log keystore loading progressively (#3699) * print initial fee recipient when loading validators * log dynamic fee recipient updates
I was recently gifted a stack of Görli eth to stake on Prater and thought this would be a good time to run a serious staking setup with nimbus! While configuring the setup, I ran into a few problems (all self-imposed) that I feel could be better illuminated through logging. These are kind of from memory so please forgive me if I get something confused.
NOT
is not a terribly reassuring log prefix msg to be seeing while importing validator keys (nimbus deposits import
).--validators-dir
and--secrets-dir
state the argument is "a directory containing X", but I believe the actual expected value is a directory containing another directory, which contains X.validators
orsecrets
causes nimbus to simply ignore them. IMO if those directories exist, but have invalid permissions that should at least be logged as aWARN
if not outrightFATAL
.--insecure
is a kind of a concerning flag name to pass to a piece of software I'm about to delegate tens of thousands of (hypothetical) euros to (yes I see if you don't want metrics you don't need it, but still).validator_keys
directory into the nimbus repository and then run a command (nimbus deposits import
) whose path defaults to the current directory. Would much rather it be agnostic to where the user has placed their files.The text was updated successfully, but these errors were encountered: