Enable validator monitor by default #4468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
force-pushed
the
vmon-de-beta
branch
3 times, most recently
from
a943222
to
f0cc0e9
Compare
By enabling the validator monitor, more precise information about the lifecycle of an attestation is logged at the higher `NOTICE` log level while current `sent` messages are logged at `INF` instead, since they are less interesting. In particular, missed attestations and those that vote for the wrong head are now detected and logged at NOTICE. In addition to logging, this feature enables rich metrics around attestation and sync committee performance - by default, validators are tracked in aggregate but a detailed mode exists as well This feature has been available since early Nimbus days, but it has now been tuned and optimised such that it is safe to enable by default, even for large setups. * enable automatic validator monitoring by default * replace `--validator-monitor-totals` flag with `--validator-monitor-details` - the detailed mode is disabled by default * lower "sent" log level to `INF` for several messages - in particular those that are traced by the validator monitor This is a retake on #3531 which was later reverted in #3578.
arnetheduck
force-pushed
the
vmon-de-beta
branch
from
f0cc0e9
to
12fef9b
Compare
jakubgs
added a commit
to status-im/infra-role-beacon-node-macos
that referenced
this pull request
Jun 7, 2023
Replaced `--validator-monitor-totals` in: status-im/nimbus-eth2#4468 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/infra-role-beacon-node-windows
that referenced
this pull request
Jun 7, 2023
Replaced `--validator-monitor-totals` in: status-im/nimbus-eth2#4468 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/infra-role-beacon-node-linux
that referenced
this pull request
Jun 7, 2023
Replaced `--validator-monitor-totals` in: status-im/nimbus-eth2#4468 Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
added a commit
to status-im/infra-nimbus
that referenced
this pull request
Jun 7, 2023
Replaced `--validator-monitor-totals` in: status-im/nimbus-eth2#4468 Signed-off-by: Jakub Sokołowski <jakub@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By enabling the validator monitor, more precise information about the lifecycle of an attestation is logged at the higher
NOTICElog level while currentsentmessages are logged atINFinstead, since they are less interesting.In particular, missed attestations and those that vote for the wrong head are now detected and logged at NOTICE.
In addition to logging, this feature enables rich metrics around attestation and sync committee performance - by default, validators are tracked in aggregate but a detailed mode exists as well.
This feature has been available since early Nimbus days, but it has now been tuned and optimised such that it is safe to enable by default, even for large setups.
--validator-monitor-totalsflag with--validator-monitor-details- the detailed mode is disabled by defaultINFfor several messages - in particular those that are traced by the validator monitorThis is a retake on #3531 which was later reverted in #3578.