VC: Fix issue when optimistically synced node could block sync committee service functions. #4878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
May 1, 2023
| @@ -360,8 +360,7 @@ proc publishSyncMessagesAndContributions(service: SyncCommitteeServiceRef, | |||
| res.data.root | |||
| else: | |||
| if res.execution_optimistic.get(): | |||
| notice "Execution client not in sync; skipping validator duties " & | |||
| "for now", slot = slot | |||
| notice "Execution client not in sync", slot = slot | |||
There was a problem hiding this comment.
per changes to getHeadBlockRoot we can no longer end up in this branch of the logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was reported in discord chat and it affects scenario when multiple BN get used and some of them are optimistically synced.