Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query sync duties for correct slot #5083

Merged
merged 1 commit into from
Jun 16, 2023
Merged

query sync duties for correct slot #5083

merged 1 commit into from
Jun 16, 2023

Conversation

etan-status
Copy link
Contributor

VC currently misses sync committee duties for first slot of most epochs because the 1 slot offset is not taken into account. Duties for the next slot must be used during any given current slot. We use the correct slot for processing the duty, but do not use the correct slot for fetching.

@etan-status
query sync duties for correct slot
05f2095 
VC currently misses sync committee duties for first slot of most epochs
because the 1 slot offset is not taken into account. Duties for the next
slot must be used during any given current slot. We use the correct slot
for processing the duty, but do not use the correct slot for fetching.
etan-status added a commit that referenced this pull request Jun 15, 2023
@etan-status
require sync committee supermajority in CI
9c59758 
To better catch problems with sync committee messages in CI, extend
local testnet simulation to also verify that each block is signed
by a supermajority of the sync committee.

Requires #5083 and #5084
@etan-status etan-status mentioned this pull request Jun 15, 2023
Merged
@github-actions
Copy link

Unit Test Results

         9 files  ±0    1 071 suites  ±0   37m 1s ⏱️ + 1m 19s
  3 698 tests ±0    3 419 ✔️ ±0  279 💤 ±0  0 ❌ ±0 
15 760 runs  ±0  15 455 ✔️ ±0  305 💤 ±0  0 ❌ ±0 

Results for commit 05f2095. ± Comparison against base commit a6f0a7a.

@tersec tersec merged commit 6f68c1a into unstable Jun 16, 2023
8 checks passed
@tersec tersec deleted the dev/etan/vc-syncepoch branch June 16, 2023 06:33
tersec pushed a commit that referenced this pull request Jun 16, 2023
@etan-status @tersec
require sync committee supermajority in CI
4dd17d7 
To better catch problems with sync committee messages in CI, extend
local testnet simulation to also verify that each block is signed
by a supermajority of the sync committee.

Requires #5083 and #5084
tersec pushed a commit that referenced this pull request Jun 16, 2023
@etan-status @tersec
require sync committee supermajority in CI
4fececd 
To better catch problems with sync committee messages in CI, extend
local testnet simulation to also verify that each block is signed
by a supermajority of the sync committee.

Requires #5083 and #5084
tersec pushed a commit that referenced this pull request Jun 17, 2023
@etan-status
require sync committee supermajority in CI (#5085)
3a6b50c 
* require sync committee supermajority in CI

To better catch problems with sync committee messages in CI, extend
local testnet simulation to also verify that each block is signed
by a supermajority of the sync committee.

Requires #5083 and #5084

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tersec tersec tersec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etan-status @tersec