Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure sync duties for next epoch are registered in time #5084

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

etan-status
Copy link
Contributor

For attestations, VC queries duties for current and next epoch. For sync messages, VC queries for current and next period (if soon). This means that for sync messages we don't actually have the duties for next epoch in all situations, leading to situation where VC may miss sync duties in the final slot of an epoch when using. As duties remain same within a sync committee period, simply copy them over to next epoch to avoid this situation without adding network latency.

For attestations, VC queries duties for current and next epoch.
For sync messages, VC queries for current and next period (if soon).
This means that for sync messages we don't actually have the duties for
next epoch in all situations, leading to situation where VC may miss
sync duties in the final slot of an epoch when using. As duties remain
same within a sync committee period, simply copy them over to next epoch
to avoid this situation without adding network latency.
etan-status added a commit that referenced this pull request Jun 15, 2023
To better catch problems with sync committee messages in CI, extend
local testnet simulation to also verify that each block is signed
by a supermajority of the sync committee.

Requires #5083 and #5084
Co-authored-by: Jacek Sieka <jacek@status.im>
@github-actions
Copy link

Unit Test Results

         9 files  ±0    1 071 suites  ±0   39m 27s ⏱️ + 3m 45s
  3 698 tests ±0    3 419 ✔️ ±0  279 💤 ±0  0 ±0 
15 760 runs  ±0  15 455 ✔️ ±0  305 💤 ±0  0 ±0 

Results for commit 058b5d3. ± Comparison against base commit a6f0a7a.

tersec pushed a commit that referenced this pull request Jun 16, 2023
To better catch problems with sync committee messages in CI, extend
local testnet simulation to also verify that each block is signed
by a supermajority of the sync committee.

Requires #5083 and #5084
@arnetheduck
Copy link
Member

It does feel like the duties should really be keyed by sync committee period + dependent root here here rather than epoch - this would resolve this problem and avoid the extreme strain on the CPU due to the extra division potentially introduced in the future if period ratios become non-constant.

@tersec tersec merged commit e9262ab into unstable Jun 16, 2023
8 checks passed
@tersec tersec deleted the dev/etan/vc-syncnext branch June 16, 2023 08:42
tersec pushed a commit that referenced this pull request Jun 16, 2023
To better catch problems with sync committee messages in CI, extend
local testnet simulation to also verify that each block is signed
by a supermajority of the sync committee.

Requires #5083 and #5084
tersec pushed a commit that referenced this pull request Jun 17, 2023
* require sync committee supermajority in CI

To better catch problems with sync committee messages in CI, extend
local testnet simulation to also verify that each block is signed
by a supermajority of the sync committee.

Requires #5083 and #5084

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants