Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to current (deprecated, but) version of produceBlindedBlock #5639

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Dec 3, 2023

https://ethereum.github.io/beacon-APIs/#/Validator/produceBlindedBlock is deprecated (ethereum/beacon-APIs#339) and #5474 has been merged, but pending Nimbus validator client of produceBlockV3, add some Deneb builder API support to produceBlindedBlock as specified.

As of ethereum/beacon-APIs#369 for Deneb blinded blocks, it returns only the block, nothing related to sidecars.

Eventually, this entire function can be marked Http410 and the supporting infrastructure can be removed, once produceBlockV3 is supported widely enough.

@tersec tersec enabled auto-merge (squash) December 3, 2023 07:55
Copy link

github-actions bot commented Dec 3, 2023

Unit Test Results

         9 files  ±0    1 098 suites  ±0   27m 24s ⏱️ -30s
  3 953 tests ±0    3 606 ✔️ ±0  347 💤 ±0  0 ±0 
16 072 runs  ±0  15 674 ✔️ ±0  398 💤 ±0  0 ±0 

Results for commit 865f5c9. ± Comparison against base commit 2fc43c9.

@tersec tersec merged commit 144d453 into unstable Dec 3, 2023
11 checks passed
@tersec tersec deleted the 97K branch December 3, 2023 09:04
etan-status added a commit that referenced this pull request Dec 4, 2023
For Deneb, extend on #5639 and use correct KZG commitments when
producing new blinded blocks using Nimbus VC.
etan-status added a commit that referenced this pull request Dec 4, 2023
)

For Deneb, extend on #5639 and use correct KZG commitments when
producing new blinded blocks using Nimbus VC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant