clear BrokenClock
status if Nimbus extensions no longer supported
#5827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When BN clock is out of sync, VC sets BN status to
BrokenClock
. It is only reset toOffline
after restoring time sync. However, if VC fails encounters an error while checking time, Nimbus extensions are assumed to be unavailable and the BN is no longer checked for having a synced clock. This means it is never reset back toOffline
if errors start occurring after BN is already set toBrokenClock
. This could be because BN is changed from Nimbus to an alternative implementation, or due to intermittent connection issues.Ensure that BN status is reset back to
Offline
when Nimbus extensions are disabled to ensure eventual connection recovery.