fix(rln): set maxEpochGap as maximum epoch gap #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1fr0
added
the
track:rln
|
LGTM, thanks 😁 |
richard-ramos
approved these changes
Oct 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to 17/WAKU-RLN-RELAY RFC:
Currently, messages with gap equal to
maxEpochGapare marked as invalid. This PR fixes the epoch gap check in order to mark invalid only messages with epoch gap greater thanmaxEpochGap.@staheri14 This change seems further beneficial for rln-js where, when debugging with the browser console open, proof generation could take 10s and messages will be relayed much later than when created (and discarded). We might revert or adjust maxEpochGap in further PRs with a deeper analysis.