Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make index page and upload notes #13

Merged
merged 2 commits into from
Jan 25, 2019
Merged

Conversation

johnlenin00
Copy link
Contributor

closes #12

@oskarth oskarth self-requested a review January 25, 2019 02:53
README.md Outdated
4 | Mon, September 17, 2018 at 12:00 UTC | [notes](notes/meeting4.md) | [video](https://www.youtube.com/watch?v=p01rnaEc3B0)
3 | Mon, September 3, 2018 at 12:00 UTC | [notes](notes/meeting3.md) | [video](https://www.youtube.com/watch?v=Mb58gDHWFIg)
2 | Mon, August 20, 2018 at 12:00 UTC | [notes](notes/meeting2.md) | [video](https://www.youtube.com/watch?v=4r-F9SkriEo)
1 | Mon, August 6, 2018 at 12:00 UTC | [notes](notes/meeting1.md) | [video](https://www.youtube.com/watch?v=P_jo4Y39tRk)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to make sure sorting works, could we either:

  • ensure notes are double digits, e.g. notes/meeting01.md
  • alternative would be to add date in name, e.g. notes/180806.md

Either would work imo

tags: core dev call, meeting notes
---

Agenda https://notes.status.im/sSwbEGg9TEWfxpOnLMPE_Q
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add the agenda in-line like in the previous notes?

Copy link
Contributor

@oskarth oskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor feedback, otherwise looks good!

README.md Outdated
№ | Date | Notes | Recording |
---|---|---|---|
10 | Mon, January 14, 2019 at 13:00 UTC | [notes](notes/meeting10.md) | [video](https://www.youtube.com/watch?v=4vWaqa38Hrs)
9 | Mon, December 17, 2018 at 13:00 UTC | [notes](notes/meeting9.md), [agenda](notes/meeting9-agenda.md) | [video](https://www.youtube.com/watch?v=HVylXrDBJHg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add the agenda in-line at the top of the two notes? This way it doesn't depend on hackmd link still existing.

@johnlenin00
Copy link
Contributor Author

ok. I'll change the filenames to double digits and I'll move the agenda into the notes, to replace the hackmd links. I'll delete the "meeting9-agenda.md" and "meeting8-agenda.md" files because they become redundant afterwards.

@johnlenin00
Copy link
Contributor Author

@oskarth ok I updated it, let me know if it is good now..

Copy link
Contributor

@oskarth oskarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @johnlenin00! LGTM

@oskarth oskarth merged commit a5e4a65 into status-im:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload notes and create index with Core dev notes
2 participants