-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make index page and upload notes #13
Conversation
README.md
Outdated
4 | Mon, September 17, 2018 at 12:00 UTC | [notes](notes/meeting4.md) | [video](https://www.youtube.com/watch?v=p01rnaEc3B0) | ||
3 | Mon, September 3, 2018 at 12:00 UTC | [notes](notes/meeting3.md) | [video](https://www.youtube.com/watch?v=Mb58gDHWFIg) | ||
2 | Mon, August 20, 2018 at 12:00 UTC | [notes](notes/meeting2.md) | [video](https://www.youtube.com/watch?v=4r-F9SkriEo) | ||
1 | Mon, August 6, 2018 at 12:00 UTC | [notes](notes/meeting1.md) | [video](https://www.youtube.com/watch?v=P_jo4Y39tRk) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to make sure sorting works, could we either:
- ensure notes are double digits, e.g.
notes/meeting01.md
- alternative would be to add date in name, e.g.
notes/180806.md
Either would work imo
notes/meeting9.md
Outdated
tags: core dev call, meeting notes | ||
--- | ||
|
||
Agenda https://notes.status.im/sSwbEGg9TEWfxpOnLMPE_Q |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add the agenda in-line like in the previous notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback, otherwise looks good!
README.md
Outdated
№ | Date | Notes | Recording | | ||
---|---|---|---| | ||
10 | Mon, January 14, 2019 at 13:00 UTC | [notes](notes/meeting10.md) | [video](https://www.youtube.com/watch?v=4vWaqa38Hrs) | ||
9 | Mon, December 17, 2018 at 13:00 UTC | [notes](notes/meeting9.md), [agenda](notes/meeting9-agenda.md) | [video](https://www.youtube.com/watch?v=HVylXrDBJHg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add the agenda in-line at the top of the two notes? This way it doesn't depend on hackmd link still existing.
ok. I'll change the filenames to double digits and I'll move the agenda into the notes, to replace the hackmd links. I'll delete the "meeting9-agenda.md" and "meeting8-agenda.md" files because they become redundant afterwards. |
@oskarth ok I updated it, let me know if it is good now.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers @johnlenin00! LGTM
closes #12