Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI - Wallet Stability] Create new SQ/StatusAmountInputPanel for SendModal / BridgeModal / SwapModal #15207

Closed
Tracked by #14711
noeliaSD opened this issue Jun 17, 2024 · 8 comments · Fixed by #15644
Closed
Tracked by #14711
Assignees
Labels
E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor ui-team
Milestone

Comments

@noeliaSD
Copy link
Contributor

noeliaSD commented Jun 17, 2024

Design

Screenshot 2024-06-17 at 14 50 45

Screenshot 2024-06-17 at 14 50 37

  • Replacement for AmountToSend and AmountToReceive (maybe we can do the replacement here or keep the integration for task [UI - Wallet Stability] Refactor SendModal to use the new / reworked components #15215)
  • Generic SQ component (some basic api, but needs design check / analysis):
    • Property to allow being aligned to the left or to the right
    • Title
    • Editable input but can be also readonly
    • Subtitle
    • Status: ok / failure
  • Storybook page without warnings
  • No stores dependencies
  • Create qml tests for the component
@noeliaSD noeliaSD added E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality ui-team refactor labels Jun 17, 2024
@noeliaSD noeliaSD added this to the 2.30.0 Beta milestone Jun 17, 2024
@caybro
Copy link
Member

caybro commented Jun 17, 2024

Oh that's a new one! I like it, would definitely be a better replacement for the SwapModal/SwapInputPanel component

@noeliaSD noeliaSD changed the title Create new SQ/StatusAmountInputPanel for SendModal / BridgeModal [UI - Wallet Stability] Create new SQ/StatusAmountInputPanel for SendModal / BridgeModal Jun 17, 2024
@caybro caybro changed the title [UI - Wallet Stability] Create new SQ/StatusAmountInputPanel for SendModal / BridgeModal [UI - Wallet Stability] Create new SQ/StatusAmountInputPanel for SendModal / BridgeModal / SwapModal Jun 21, 2024
@caybro
Copy link
Member

caybro commented Jul 8, 2024

Just a reminder, this is also used in SwapModal like this: AmountToSend -> SwapInputPanel -> SwapModal

@noeliaSD
Copy link
Contributor Author

noeliaSD commented Jul 8, 2024

As decided in our sync, maybe better to create a separate and new component, only apply this new component to send and bridge AND create a separate task to do the integration of the new component to swap for the next milestone.

@Khushboo-dev-cpp
Copy link
Contributor

@micieslak as discussed, this is also something swap needs as we currently use double within the current AmountToSendInput and it causes loss of precision, As I understand from @noeliaSD the work done here will not be used in swap but a different issue will be created for it. Would be great if we can create a task for it so that its not forgotten :)

@caybro
Copy link
Member

caybro commented Jul 11, 2024

@micieslak as discussed, this is also something swap needs as we currently use double within the current AmountToSendInput and it causes loss of precision, As I understand from @noeliaSD the work done here will not be used in swap but a different issue will be created for it. Would be great if we can create a task for it so that its not forgotten :)

We don't really use a double here (but the rawValue based on the Big number) in SwapModal

@Khushboo-dev-cpp
Copy link
Contributor

@micieslak as discussed, this is also something swap needs as we currently use double within the current AmountToSendInput and it causes loss of precision, As I understand from @noeliaSD the work done here will not be used in swap but a different issue will be created for it. Would be great if we can create a task for it so that its not forgotten :)

We don't really use a double here (but the rawValue based on the Big number) in SwapModal

@caybro
Copy link
Member

caybro commented Jul 11, 2024

@micieslak as discussed, this is also something swap needs as we currently use double within the current AmountToSendInput and it causes loss of precision, As I understand from @noeliaSD the work done here will not be used in swap but a different issue will be created for it. Would be great if we can create a task for it so that its not forgotten :)

We don't really use a double here (but the rawValue based on the Big number) in SwapModal

Yes, but in SwapModal we use the "text" for display, and rawValue when sending the transaction right?

But general yeah, there should be ideally no floats/doubles around in that code

@Khushboo-dev-cpp
Copy link
Contributor

@micieslak as discussed, this is also something swap needs as we currently use double within the current AmountToSendInput and it causes loss of precision, As I understand from @noeliaSD the work done here will not be used in swap but a different issue will be created for it. Would be great if we can create a task for it so that its not forgotten :)

We don't really use a double here (but the rawValue based on the Big number) in SwapModal

Yes, but in SwapModal we use the "text" for display, and rawValue when sending the transaction right?

But general yeah, there should be ideally no floats/doubles around in that code

The thing is that these floats are used to calculate the rawValue in the end and thats whats causing the issue withe losing precision.

micieslak added a commit that referenced this issue Jul 17, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
micieslak added a commit that referenced this issue Jul 18, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
micieslak added a commit that referenced this issue Jul 18, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
micieslak added a commit that referenced this issue Jul 18, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
micieslak added a commit that referenced this issue Jul 18, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
micieslak added a commit that referenced this issue Jul 18, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
micieslak added a commit that referenced this issue Jul 18, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
micieslak added a commit that referenced this issue Jul 18, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
micieslak added a commit that referenced this issue Jul 18, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
micieslak added a commit that referenced this issue Jul 18, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
micieslak added a commit that referenced this issue Jul 19, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
micieslak added a commit that referenced this issue Jul 19, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
micieslak added a commit that referenced this issue Jul 19, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
micieslak added a commit that referenced this issue Jul 19, 2024
- new AmountToSend used in SendModal
- MaxSendButton simplified

Closes: #15207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor ui-team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants