-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI - Wallet Stability] Create new SQ/StatusAmountInputPanel
for SendModal / BridgeModal / SwapModal
#15207
Comments
Oh that's a new one! I like it, would definitely be a better replacement for the SwapModal/SwapInputPanel component |
SQ/StatusAmountInputPanel
for SendModal / BridgeModalSQ/StatusAmountInputPanel
for SendModal / BridgeModal
SQ/StatusAmountInputPanel
for SendModal / BridgeModalSQ/StatusAmountInputPanel
for SendModal / BridgeModal / SwapModal
Just a reminder, this is also used in SwapModal like this: AmountToSend -> SwapInputPanel -> SwapModal |
As decided in our sync, maybe better to create a separate and new component, only apply this new component to send and bridge AND create a separate task to do the integration of the new component to swap for the next milestone. |
@micieslak as discussed, this is also something swap needs as we currently use double within the current AmountToSendInput and it causes loss of precision, As I understand from @noeliaSD the work done here will not be used in swap but a different issue will be created for it. Would be great if we can create a task for it so that its not forgotten :) |
We don't really use a double here (but the |
|
Yes, but in SwapModal we use the "text" for display, and But general yeah, there should be ideally no floats/doubles around in that code |
The thing is that these floats are used to calculate the rawValue in the end and thats whats causing the issue withe losing precision. |
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
- new AmountToSend used in SendModal - MaxSendButton simplified Closes: #15207
Design
AmountToSend
andAmountToReceive
(maybe we can do the replacement here or keep the integration for task [UI - Wallet Stability] RefactorSendModal
to use the new / reworked components #15215)The text was updated successfully, but these errors were encountered: