Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI - Wallet Stability] Refactor SendModal to use the new / reworked components #15215

Closed
6 of 9 tasks
Tracked by #14711
noeliaSD opened this issue Jun 17, 2024 · 3 comments
Closed
6 of 9 tasks
Tracked by #14711
Assignees
Labels
blocked E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor ui-team
Milestone

Comments

@noeliaSD
Copy link
Contributor

noeliaSD commented Jun 17, 2024

It should contain:

Some pseudo-code:

StatusDialog {
    id: root

    property var selectedAccount
    property var selectedToken
    property var selectedAmount
    property var selectedReceiver
    property var bestRoutes

    property models needed

    header: AccountSelector { ... }

    ColumnLayout {
        RowLayout {
            Send Text
            +
            Holdings selector
            +
            Max button component
        }
        RowLayout {
           StatusAmountInputPanel 1 (send)
           StatusAmountInputPanel 2 (receive)
        }

        Loader {
               ReceipientsSelector OR RouterPanel
        }
    }

    footer: TransactionModalFooter { ... }
}

It should implement the new design flow defined in here:

Screenshot 2024-06-17 at 16 44 06

@noeliaSD noeliaSD changed the title [UI - Wallet Stability] Refactor SendModal to use the new components / reworked components [UI - Wallet Stability] Refactor SendModal to use the new / reworked components Jun 17, 2024
@noeliaSD noeliaSD added this to the 2.30.0 Beta milestone Jun 17, 2024
@noeliaSD noeliaSD added refactor ui-team E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality labels Jun 17, 2024
@noeliaSD
Copy link
Contributor Author

First it is needed to work on the subtasks mentioned on the description

@noeliaSD
Copy link
Contributor Author

When working on this task, please ensure we are covering the following fix: #14923

If necessary, create specific qml test for the bug so we have coverage there!

@micieslak
Copy link
Member

The work will be continued in #15688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked E:D Wallet SendModal Stabilize, improve and sync with expected design and functionality refactor ui-team
Projects
Status: Done
Development

No branches or pull requests

2 participants