Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New invite to group chat will be not sent if user left chat and then will be readded #10390

Closed
churik opened this issue Apr 21, 2020 · 6 comments

Comments

@churik
Copy link
Member

churik commented Apr 21, 2020

Bug Report

Problem

Currently, we have odd behavior after user left and was readded by admin - chat is not recreated and user doesn't receive the invite.
As a user, I want to be warned that if I left chat - it is forever and I can't be added to the same group again if this behavior is expected.

Expected behavior

User is warned about consequences

Actual behavior

User can be added but doesn't receive the invite

Reproduction

  • As user A: create group chat with User B
  • As User B: join to group chat
  • As User B: left group chat
  • As User A: add User B to the same group chat again

Additional Information

  • Status version: release v.1.3
  • Operating System: Android, iOS
@churik
Copy link
Member Author

churik commented Apr 21, 2020

@hesterbruikman would like to have your opinion on this, thank you!

@hesterbruikman
Copy link
Contributor

Agree, that's unexpected behavior. Seems more like user B's action is abandon instead of leave. So either we can think of copy changes to better reflect what happens or allow re-adding. @cammellos can you please explain why a user cannot be re-added after leaving a group chat?

@cammellos
Copy link
Member

User can be re-added to a chat from a technical perspective,I think it's just a choice we have to make, no technical reason to be one way or the other.

@errorists
Copy link
Contributor

errorists commented Apr 22, 2020

it shouldn't be a one-way street: one of admins removes a user, anyone who's a group admin can choose to add him back, the same flow is repeated again when the user was added for the first time. there's no limit in place on how many times a user can be removed and invited back, the same goes for leaving the chat by the user

@cammellos
Copy link
Member

cool, we can change the behavior

@errorists
Copy link
Contributor

@cammellos thank you!

cammellos added a commit that referenced this issue Apr 22, 2020
If we get re-invited to a chat that we left, the chat will be shown
again.
cammellos added a commit that referenced this issue Apr 23, 2020
If we get re-invited to a chat that we left, the chat will be shown
again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants