Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoted text (using markdown) in dark mode is hardly visible #10396

Closed
churik opened this issue Apr 22, 2020 · 6 comments · Fixed by #10406
Closed

Quoted text (using markdown) in dark mode is hardly visible #10396

churik opened this issue Apr 22, 2020 · 6 comments · Fixed by #10406

Comments

@churik
Copy link
Member

churik commented Apr 22, 2020

Bug Report

Problem

Monosnap 2020-04-22 10-32-55

Expected behavior

Text is more visible

Actual behavior

see screenshot

Reproduction

  • User A: join to public chat, send message with quoted text( i.e. > aaaaaaa)
  • User B: join same public chat

Additional Information

  • Status version: release v1.3
  • Operating System: Android, iOS
@churik churik added the bug label Apr 22, 2020
@flexsurfer flexsurfer self-assigned this Apr 22, 2020
@errorists
Copy link
Contributor

you guys are awesome, good catch! I've filled in all the markdown values for dark theme here

@errorists
Copy link
Contributor

errorists commented Apr 22, 2020

@flexsurfer while we're at it, would it be possible please to correct the chat avatar initial, it should be the same for both dark theme and light, currently as you can see on the screenshot attached in the issue the text is dark?
Screenshot 2020-04-22 at 14 38 16

@flexsurfer
Copy link
Member

@errorists done
image

@errorists
Copy link
Contributor

@flexsurfer legend, as always 🙏

@flexsurfer
Copy link
Member

@errorists @churik super local change, do you want this to be cherry picked in 1.3 ? i think chat avatar initial would be nice to have in 1.3 wdyt ?

@errorists
Copy link
Contributor

It would be cool if we could introduce the dark mode in as good shape as possible, yes

flexsurfer added a commit that referenced this issue Apr 22, 2020
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
flexsurfer added a commit that referenced this issue Apr 22, 2020
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants