First carrousel image onboarding is cut off #10427
Assignees
Projects
Comments
|
@hesterbruikman, which device is this? I've tested on a Pixel 2 and cannot replicate. |
|
Ah interesting. This is on Galaxy S10e. Let me check iPhone 👀 |
emizzle
pushed a commit
that referenced
this issue
Apr 27, 2020
Fixes #10427 ### Summary Narrow devices were causing text in the intro carousel to grow to two lines on *the first* slide but not others, causing the height to be recalculated incorrectly on the last slide (that only had one line of text). Create a vector of atoms that can individually track the heights required for each slide independently. ### Testing notes #### Areas that maybe impacted - Intro screen status: ready
|
@hesterbruikman -- seemed to happen on narrow devices (where the title was pushed to two lines). See the comments in #10442 as there is some UI guidance needed. |
|
Good catch, looks like that's it. Just checked iPhone 8 which is fine too. @errorists any advice on how to handle text on small screens in onboarding carousel? |
|
@hesterbruikman I already commented in the issue |
emizzle
pushed a commit
that referenced
this issue
Apr 29, 2020
Fixes #10427 Narrow devices were causing text in the intro carousel to grow to two lines on *the first* slide but not others, causing the height to be recalculated incorrectly on the last slide (that only had one line of text). Create a vector of atoms that can individually track the heights required for each slide independently. - Intro screen status: ready
flexsurfer
pushed a commit
that referenced
this issue
May 6, 2020
…ow to two lines on *the first* slide but not others, causing the height to be recalculated incorrectly on the last slide (that only had one line of text).
flexsurfer
pushed a commit
that referenced
this issue
May 6, 2020
…ow to two lines on *the first* slide but not others, causing the height to be recalculated incorrectly on the last slide (that only had one line of text).
flexsurfer
pushed a commit
that referenced
this issue
May 6, 2020
…ow to two lines on *the first* slide but not others, causing the height to be recalculated incorrectly on the last slide (that only had one line of text).
flexsurfer
pushed a commit
that referenced
this issue
May 7, 2020
…ow to two lines on *the first* slide but not others, causing the height to be recalculated incorrectly on the last slide (that only had one line of text).
flexsurfer
pushed a commit
that referenced
this issue
May 8, 2020
…ow to two lines on *the first* slide but not others, causing the height to be recalculated incorrectly on the last slide (that only had one line of text). Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
|
Fixed in #10442 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
In dark mode it becomes visible that the walkie-talkie is cut off at the bottom.
Implementation
Requires investigation as to why the image is cut off.
Specification of image size, position and padding in Figma
Acceptance Criteria
Full image is shown
Notes
cc @errorists for review
Future Steps
The text was updated successfully, but these errors were encountered: