[#9749] Support importing private key and seed #10100

flexsurfer · 2020-02-28T11:40:08Z

fixes #9749

QA: keycard is not supported #10101

status-github-bot · 2020-02-28T11:40:14Z

Pull Request Checklist

Docs: Updated the documentation, if affected
Docs: Added or updated inline comments explaining intention of the code
Tests: Ensured that all new UI elements have been assigned accessibility IDs
Tests: Signaled need for E2E tests with label, if applicable
Tests: Briefly described what was tested and what platforms were used
UI: In case of UI changes, ensured that UI matches Figma
UI: In case of UI changes, requested review from a Core UI designer
UI: In case of UI changes, included screenshots of implementation

status-im-auto · 2020-02-28T11:51:02Z

Jenkins Builds

Click to see older builds (15)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`d64fc99`	#1	2020-02-28 11:51:02	~10 min	`ios`	📦`ipa` 📲
✔️	`d64fc99`	#1	2020-02-28 11:54:14	~13 min	`android-e2e`	📦`apk` 📲
✔️	`d64fc99`	#1	2020-02-28 12:00:02	~19 min	`android`	📦`apk` 📲

✔️	`18d2221`	#2	2020-02-28 12:55:40	~10 min	`ios`	📦`ipa` 📲
✔️	`18d2221`	#2	2020-02-28 12:56:54	~11 min	`android-e2e`	📦`apk` 📲
✔️	`18d2221`	#2	2020-02-28 13:06:44	~21 min	`android`	📦`apk` 📲

✔️	`34b4372`	#3	2020-02-28 15:42:14	~10 min	`ios`	📦`ipa` 📲
✔️	`34b4372`	#3	2020-02-28 15:45:52	~13 min	`android-e2e`	📦`apk` 📲
✔️	`34b4372`	#3	2020-02-28 15:45:52	~13 min	`android`	📦`apk` 📲

✔️	`6575b94`	#4	2020-03-02 11:08:14	~11 min	`ios`	📦`ipa` 📲
✔️	`6575b94`	#4	2020-03-02 11:11:04	~14 min	`android-e2e`	📦`apk` 📲
✔️	`6575b94`	#4	2020-03-02 11:11:04	~14 min	`android`	📦`apk` 📲

✔️	`134a675`	#5	2020-03-02 11:22:49	~10 min	`ios`	📦`ipa` 📲
✔️	`134a675`	#5	2020-03-02 11:25:34	~12 min	`android`	📦`apk` 📲
✔️	`134a675`	#5	2020-03-02 11:25:34	~13 min	`android-e2e`	📦`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`f706a61`	#7	2020-03-02 11:48:34	~10 min	`ios`	📦`ipa` 📲
✔️	`f706a61`	#7	2020-03-02 11:50:51	~12 min	`android-e2e`	📦`apk` 📲
✔️	`f706a61`	#7	2020-03-02 11:52:13	~13 min	`android`	📦`apk` 📲

✔️	`9515f03`	#8	2020-03-02 16:20:04	~11 min	`ios`	📦`ipa` 📲
✔️	`9515f03`	#8	2020-03-02 16:22:49	~14 min	`android-e2e`	📦`apk` 📲
✔️	`9515f03`	#8	2020-03-02 16:22:49	~14 min	`android`	📦`apk` 📲

yenda · 2020-02-28T12:01:15Z

src/status_im/multiaccounts/recover/core.cljs

@@ -24,7 +24,7 @@
  (contains? multiaccounts key-uid))

 (re-frame/reg-fx
- ::validate-mnemonic
+ :validate-mnemonic


why remove the namespace?

yenda · 2020-02-28T12:02:38Z

src/status_im/wallet/accounts/core.cljs

+(fx/defn import-new-account-seed
+  [{:keys [db]} passphrase hashed-password]
+  {:db                   (assoc-in db [:add-account :step] :generating)
+   :validate-mnemonic   [(security/safe-unmask-data passphrase)


keep the namespaced keywords and import via alias, if there is a circular dep it just means that the effect is not in the right place from a code organization pov

churik · 2020-02-28T12:21:44Z

ISSUE 1: field seed phrase is case-sensitive and contains autosuggestion

Steps:

open status
go to wallet > Add account > Enter seed phrase (try with capital letters)

Expected result:
Seed phrase input have the same validation rules as in flow for recovery account

Actual result:

Also, keyboard has turned on autosuggestion when focusing in field (referred to the issue #9034)

churik · 2020-02-28T12:42:31Z

ISSUE 2: Can add account with invalid password

Steps:

open status
go to wallet > Add account > Enter seed phrase
type invalid password
fill other fields

Expected result:
Validation error

Actual result:

but account is added

flexsurfer · 2020-02-28T12:46:03Z

issue1 : fixed

flexsurfer · 2020-02-28T12:48:41Z

@churik can't reproduce issue 2, btw for importing seed and private key there is no wrong password, because you can use any password you want, yeah i know its confusing

flexsurfer · 2020-02-28T12:53:39Z

summon @hesterbruikman , so when you import accounts with seed or private key, you can use any new password to import them , that might be confusing for sure

hesterbruikman · 2020-02-28T13:46:26Z

summon @hesterbruikman , so when you import accounts with seed or private key, you can use any new password to import them , that might be confusing for sure

If I recall correctly this should be your existing password. Also as it says, Enter your password. cc @guylouis to verify

If it is indeed the existing password, validation is missing

flexsurfer · 2020-02-28T13:52:21Z

@hesterbruikman we just store new account on the device we can use any password, it's not related anyhow to multiaccount, so its up to us how we want to implement it, if we want new password we should ask it twice , if multiaccount, we need to verify it somehow @gravityblast ?

hesterbruikman · 2020-02-28T14:13:23Z

I'm pretty sure the idea was to simply ask for the same password as to not let people juggle different passwords to sign within the same multiaccount in Status. That's why there's no confirm password and we only say Enter your password. Exception is the case where keys are encrypted with a password set up elsewhere.

guylouis · 2020-02-28T14:25:47Z

100%

In my mind, from our past discussions, a new account imported from a private key should be protected the same way an account on the BIP44 tree is, and we should not create a new password to avoid any added complexity.

If the private key is encrypted in a json file (but I don't think this issue is about this case) of course, that's something else and at the time of importing, this encryption password is being asked.

flexsurfer · 2020-02-28T15:32:31Z

@churik issue 2 fixed, also now we check if password is the same as for multiaccount

churik · 2020-02-28T15:47:48Z

ISSUE 3: Keychain suggests to save password

Steps:

open status
go to wallet > Add account > Enter seed phrase
fill all fields
proceed

Expected result:
Account is added, no suggestions about storing password

Actual result:

churik · 2020-02-28T15:56:59Z

ISSUE 4: Can add 2 accounts with same seed

Steps:

open status
go to wallet > Add account > Enter seed phrase
fill all fields
proceed
repeat steps 2-5 with same seed phrase

Expected result:
can't add same account twice

Actual result:

It will be deleted if you relogin.
Actually you can create new account with same seed phrase via recovery flow as well - not sure what is expected result here.

flexsurfer · 2020-02-28T16:08:35Z

ISSUE 3 - hm is this solved somehow for other password fields ? i remember we had this but not sure how we solved it

churik · 2020-02-28T16:11:36Z

@flexsurfer
#8837 - seems it's gone after redesign, but it appeared again here

churik · 2020-02-28T17:02:19Z

ISSUE 7: With whitspaces between, after or before seed phrase restores different account

See #9670

Steps:

open status
go to wallet > Add account > Enter seed phrase
on seed phrase put spaces in the end of phrase
fill all fields
proceed

Expected result:
account is restored according to trimmed seed phrase

Actual result:
with whitespaces in different places different accounts are recovered

churik · 2020-02-28T17:12:30Z

@flexsurfer here fix for several cases will be required (and ideally 2 new cases).
So please wait for my commit.
Also would be awesome if you can add accessibility-ids to all fields in new screens - it makes e2e easier to support.
Thanks!

rasom · 2020-03-02T07:06:11Z

src/status_im/wallet/accounts/core.cljs

+                    {:address    address
+                     :public-key publicKey
+                     :type       type
+                     :path       (if (string/starts-with? path "m/")


can we extract this path derivation part to a separate fn?

rasom · 2020-03-02T07:08:20Z

src/status_im/wallet/accounts/core.cljs

+                                        "/" (last (string/split path "/")))
+                                   path)}])))))))))))
+
+(def pass-error "cannot retrieve a valid key for a given account: could not decrypt key with given password")


Is that returned form status-go side? We probably need to start using error codes or something, because comparing messages might not be the best idea and definitely isn't a very reliable way.

rasom · 2020-03-02T07:11:36Z

src/status_im/wallet/accounts/core.cljs

+   (status/verify address hashed-password
+                  #(re-frame/dispatch [:wallet.accounts/add-new-account-password-verifyied
+                                       %
+                                       hashed-password]))))


(status/verify address hashed-password #(re-frame/dispatch [:wallet.accounts/add-new-account-password-verifyied % hashed-password]))))

not a big deal, but that lonely percent sign looks weird to me

flexsurfer · 2020-03-02T10:58:27Z

@churik thanks all issue fixed
ISSUE 3 - can't be fixed

churik · 2020-03-02T11:26:01Z

@corpetty
is it OK to release this feature with #10100 (comment) ?
Seems there is no way to fix it shortly.

status-im-auto · 2020-03-02T16:15:58Z

100% of end-end tests have passed

Total executed tests: 4
Failed tests: 0
Passed tests: 4

Passed tests (4)

Click to expand

1. test_add_account_to_multiaccount_instance_seed_phrase
Device sessions Device 1: Steps, video, logs
2. test_add_account_to_multiaccount_instance_private_key
Device sessions Device 1: Steps, video, logs
3. test_add_account_to_multiaccount_instance_generate_new
Device sessions Device 1: Steps, video, logs
4. test_mobile_data_usage_popup_stop_syncing
Device sessions Device 1: Steps, video, logs

churik · 2020-03-03T10:49:50Z

Tested:

fields validation on new screens
using new types of accounts in DApps + collectibles
changing settings on new accounts
using new accounts in commands
using ENS from main account
adding account via seed phrase in wallet and restoring it in user flow
changing networks
attempt to add the same account twice (seed phrase + public key)
search for sensitive info in logs

Apart from #9895 and #8837 don't see other issues.
Amazing work!

Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>

hesterbruikman · 2020-03-03T12:39:15Z

👋@flexsurfer what's the behavior for Keycard in this current implementation? @rasom mentioned we're missing designs for Add account > Generate keys in case of Keycard. Assuming the same is true here.

flexsurfer · 2020-03-03T12:51:12Z

the behavior is that Keycard is not supported in this PR , here is the issue #10101

flexsurfer added the request-manual-qa label Feb 28, 2020

flexsurfer requested a review from vitvly February 28, 2020 11:40

flexsurfer requested a review from a team as a code owner February 28, 2020 11:40

flexsurfer self-assigned this Feb 28, 2020

status-github-bot bot added this to REVIEW in Pipeline for QA Feb 28, 2020

auto-assign bot removed the request for review from a team February 28, 2020 11:40

flexsurfer mentioned this pull request Feb 28, 2020

Add support for adding new accounts in wallet with keycard #10101

Closed

flexsurfer moved this from REVIEW to E2E Tests in Pipeline for QA Feb 28, 2020

flexsurfer added the v1.1 release label Feb 28, 2020

churik self-assigned this Feb 28, 2020

yenda reviewed Feb 28, 2020

View reviewed changes

flexsurfer force-pushed the feature/rework-new-accounts-in-wallet branch from d64fc99 to 18d2221 Compare February 28, 2020 12:45

flexsurfer force-pushed the feature/rework-new-accounts-in-wallet branch from 18d2221 to 34b4372 Compare February 28, 2020 15:31

churik moved this from E2E Tests to TO TEST in Pipeline for QA Feb 28, 2020

weekly-digest bot mentioned this pull request Mar 1, 2020

Weekly Digest (23 February, 2020 - 1 March, 2020) #10112

Closed

rasom approved these changes Mar 2, 2020

View reviewed changes

flexsurfer mentioned this pull request Mar 2, 2020

Save Password prompt when adding new account on IOS #8837

Closed

flexsurfer force-pushed the feature/rework-new-accounts-in-wallet branch from 34b4372 to 6575b94 Compare March 2, 2020 10:56

flexsurfer force-pushed the feature/rework-new-accounts-in-wallet branch from 6575b94 to 134a675 Compare March 2, 2020 11:12

churik moved this from E2E Tests to IN TESTING in Pipeline for QA Mar 2, 2020

flexsurfer force-pushed the feature/rework-new-accounts-in-wallet branch from 83e137d to f706a61 Compare March 2, 2020 11:38

flexsurfer requested review from antdanchenko and churik as code owners March 2, 2020 16:08

churik mentioned this pull request Mar 3, 2020

Transaction state is not updated for receiver if it is received to non-default account #9895

Closed

churik mentioned this pull request Mar 3, 2020

Support importing private key #9749

Closed

churik added the Tested - OK label Mar 3, 2020

churik moved this from IN TESTING to MERGE in Pipeline for QA Mar 3, 2020

flexsurfer and others added 3 commits March 3, 2020 12:51

[#9749] Support importing private key and seed

a79a72f

accessibility-labels

f645d3f

e2e for importing accounts

7b7f567

Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>

flexsurfer force-pushed the feature/rework-new-accounts-in-wallet branch from 9515f03 to 7b7f567 Compare March 3, 2020 11:52

flexsurfer merged commit 7b7f567 into develop Mar 3, 2020

Pipeline for QA automation moved this from MERGE to DONE Mar 3, 2020

delete-merged-branch bot deleted the feature/rework-new-accounts-in-wallet branch March 3, 2020 11:52

hesterbruikman mentioned this pull request Mar 4, 2020

Import an account and store it on Keycard (within a regular multiaccount) #10128

Closed

StatusWrike unassigned flexsurfer Apr 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#9749] Support importing private key and seed #10100

[#9749] Support importing private key and seed #10100

flexsurfer commented Feb 28, 2020 •

edited by StatusWrike

status-github-bot bot commented Feb 28, 2020

status-im-auto commented Feb 28, 2020 •

edited

yenda Feb 28, 2020

flexsurfer Feb 28, 2020

yenda Feb 28, 2020

flexsurfer Feb 28, 2020

churik commented Feb 28, 2020 •

edited

churik commented Feb 28, 2020

flexsurfer commented Feb 28, 2020

flexsurfer commented Feb 28, 2020

flexsurfer commented Feb 28, 2020

hesterbruikman commented Feb 28, 2020

flexsurfer commented Feb 28, 2020

hesterbruikman commented Feb 28, 2020 •

edited

guylouis commented Feb 28, 2020

flexsurfer commented Feb 28, 2020

churik commented Feb 28, 2020

churik commented Feb 28, 2020

flexsurfer commented Feb 28, 2020 •

edited

churik commented Feb 28, 2020 •

edited

churik commented Feb 28, 2020 •

edited

churik commented Feb 28, 2020

rasom Mar 2, 2020

rasom Mar 2, 2020

rasom Mar 2, 2020

flexsurfer commented Mar 2, 2020 •

edited

churik commented Mar 2, 2020

status-im-auto commented Mar 2, 2020

churik commented Mar 3, 2020 •

edited

hesterbruikman commented Mar 3, 2020

flexsurfer commented Mar 3, 2020

[#9749] Support importing private key and seed #10100

[#9749] Support importing private key and seed #10100

Conversation

flexsurfer commented Feb 28, 2020 • edited by StatusWrike

status-github-bot bot commented Feb 28, 2020

Pull Request Checklist

status-im-auto commented Feb 28, 2020 • edited

Jenkins Builds

yenda Feb 28, 2020

Choose a reason for hiding this comment

flexsurfer Feb 28, 2020

Choose a reason for hiding this comment

yenda Feb 28, 2020

Choose a reason for hiding this comment

flexsurfer Feb 28, 2020

Choose a reason for hiding this comment

churik commented Feb 28, 2020 • edited

ISSUE 1: field seed phrase is case-sensitive and contains autosuggestion

churik commented Feb 28, 2020

ISSUE 2: Can add account with invalid password

flexsurfer commented Feb 28, 2020

flexsurfer commented Feb 28, 2020

flexsurfer commented Feb 28, 2020

hesterbruikman commented Feb 28, 2020

flexsurfer commented Feb 28, 2020

hesterbruikman commented Feb 28, 2020 • edited

guylouis commented Feb 28, 2020

flexsurfer commented Feb 28, 2020

churik commented Feb 28, 2020

ISSUE 3: Keychain suggests to save password

churik commented Feb 28, 2020

ISSUE 4: Can add 2 accounts with same seed

flexsurfer commented Feb 28, 2020 • edited

churik commented Feb 28, 2020 • edited

churik commented Feb 28, 2020 • edited

ISSUE 7: With whitspaces between, after or before seed phrase restores different account

churik commented Feb 28, 2020

rasom Mar 2, 2020

Choose a reason for hiding this comment

rasom Mar 2, 2020

Choose a reason for hiding this comment

rasom Mar 2, 2020

Choose a reason for hiding this comment

flexsurfer commented Mar 2, 2020 • edited

churik commented Mar 2, 2020

status-im-auto commented Mar 2, 2020

100% of end-end tests have passed

Passed tests (4)

churik commented Mar 3, 2020 • edited

hesterbruikman commented Mar 3, 2020

flexsurfer commented Mar 3, 2020

flexsurfer commented Feb 28, 2020 •

edited by StatusWrike

status-im-auto commented Feb 28, 2020 •

edited

churik commented Feb 28, 2020 •

edited

hesterbruikman commented Feb 28, 2020 •

edited

flexsurfer commented Feb 28, 2020 •

edited

churik commented Feb 28, 2020 •

edited

churik commented Feb 28, 2020 •

edited

flexsurfer commented Mar 2, 2020 •

edited

churik commented Mar 3, 2020 •

edited