Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] install referrer #10139

Closed
wants to merge 1 commit into from

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer commented Mar 6, 2020

  • read referrer
  • call https endpoint

wip

@flexsurfer flexsurfer requested a review from a team as a code owner March 6, 2020 09:18
@flexsurfer flexsurfer self-assigned this Mar 6, 2020
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Mar 6, 2020
@status-im-auto
Copy link
Member

status-im-auto commented Mar 6, 2020

Jenkins Builds

Click to see older builds (30)
Commit #️⃣ Finished (UTC) Duration Platform Result
df55f24 #1 2020-03-06 09:25:38 ~6 min android 📄log
df55f24 #1 2020-03-06 09:25:38 ~6 min android-e2e 📄log
✔️ df55f24 #1 2020-03-06 09:29:18 ~10 min ios 📦ipa 📲
ecb5041 #4 2020-03-06 12:37:51 ~5 min android 📄log
ecb5041 #2 2020-03-06 12:38:01 ~5 min android-e2e 📄log
✔️ ecb5041 #2 2020-03-06 12:41:34 ~8 min ios 📦ipa 📲
✔️ 3d92e6b #3 2020-03-06 12:53:38 ~8 min ios 📦ipa 📲
3d92e6b #3 2020-03-06 12:55:01 ~9 min android-e2e 📄log
3d92e6b #5 2020-03-06 12:55:48 ~10 min android 📄log
b4d31be #4 2020-03-06 13:08:19 ~8 min android-e2e 📄log
✔️ b4d31be #4 2020-03-06 13:08:25 ~8 min ios 📦ipa 📲
b4d31be #6 2020-03-06 13:09:57 ~9 min android 📄log
b80f296 #7 2020-03-06 13:22:16 ~8 min android 📄log
✔️ b80f296 #5 2020-03-06 13:22:19 ~8 min ios 📦ipa 📲
b80f296 #5 2020-03-06 13:23:34 ~9 min android-e2e 📄log
d0eb8bb #6 2020-03-06 13:34:04 ~8 min android-e2e 📄log
✔️ d0eb8bb #6 2020-03-06 13:34:13 ~8 min ios 📦ipa 📲
d0eb8bb #8 2020-03-06 13:35:25 ~9 min android 📄log
✔️ 725f1a3 #7 2020-03-06 13:49:30 ~8 min ios 📦ipa 📲
✔️ 725f1a3 #9 2020-03-06 13:50:46 ~9 min android 📦apk 📲
✔️ 725f1a3 #7 2020-03-06 13:52:29 ~11 min android-e2e 📦apk 📲
✔️ 621c273 #8 2020-03-06 14:03:46 ~8 min ios 📦ipa 📲
✔️ 621c273 #8 2020-03-06 14:06:22 ~10 min android-e2e 📦apk 📲
✔️ 621c273 #10 2020-03-06 14:07:10 ~11 min android 📦apk 📲
8c99f3b #9 2020-03-06 14:27:27 ~8 min android-e2e 📄log
✔️ 8c99f3b #9 2020-03-06 14:27:34 ~8 min ios 📦ipa 📲
8c99f3b #11 2020-03-06 14:29:01 ~9 min android 📄log
✔️ 1707118 #10 2020-03-06 14:41:19 ~9 min ios 📦ipa 📲
1707118 #10 2020-03-06 14:41:19 ~9 min android-e2e 📄log
1707118 #12 2020-03-06 14:41:52 ~9 min android 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 11675d9 #11 2020-03-06 15:00:21 ~8 min ios 📦ipa 📲
11675d9 #11 2020-03-06 15:00:29 ~8 min android-e2e 📄log
11675d9 #13 2020-03-06 15:03:59 ~12 min android 📄log
✔️ 4260b0c #12 2020-03-06 15:13:20 ~8 min ios 📦ipa 📲
✔️ 4260b0c #12 2020-03-06 15:14:47 ~9 min android-e2e 📦apk 📲
✔️ 4260b0c #14 2020-03-06 15:17:14 ~12 min android 📦apk 📲
4260b0c #13 2020-05-12 16:15:13 ~27 sec android-e2e 📄log
4260b0c #15 2020-05-12 16:15:13 ~24 sec android 📄log

@flexsurfer flexsurfer removed the request for review from a team March 6, 2020 12:18
@flexsurfer flexsurfer force-pushed the feature/install-referrer-status-module branch from 66b563b to ecb5041 Compare March 6, 2020 12:32
@flexsurfer flexsurfer requested a review from jakubgs as a code owner March 6, 2020 12:44
@flexsurfer flexsurfer removed the request for review from jakubgs March 6, 2020 12:46
@flexsurfer flexsurfer force-pushed the feature/install-referrer-status-module branch from 11675d9 to 4260b0c Compare March 6, 2020 15:04
@flexsurfer flexsurfer changed the title [wip]install referrer status module [wip] install referrer Mar 6, 2020
@status-github-bot status-github-bot bot moved this from REVIEW to CONTRIBUTOR in Pipeline for QA Mar 17, 2020
@jakubgs jakubgs closed this May 12, 2020
@jakubgs jakubgs deleted the feature/install-referrer-status-module branch May 12, 2020 13:50
Pipeline for QA automation moved this from CONTRIBUTOR to DONE May 12, 2020
@flexsurfer
Copy link
Member Author

@jakubgs why?

@jakubgs
Copy link
Member

jakubgs commented May 12, 2020

Because I asked like 3 times in #core with this list of branches:
https://gist.github.com/jakubgs/68283ba8983893dd5696578da6769a4c
If anyone objects. And no one did. So I removed them.
They were all +60 days old based on git author date.

@jakubgs
Copy link
Member

jakubgs commented May 12, 2020

Ah right, because I refreshed the list which added to it these:

change-ios-app-id
ens/remove-name
feature/install-referrer
feature/install-referrer-status-module
fix/listen-to-nfc-status#10011
fix/trim-ens-name#10115
group-chat-creation-ui-2
master
snyk-fix-02e410d84143cc400b019dc62c52a6a1
test/waku-default-eth-test-fleet
upgrade-geth-1.9.11

This is the script I used: https://github.com/status-im/infra-utils/blob/master/github/list_old_branches.sh
Feel free to reopen it.

@jakubgs jakubgs restored the feature/install-referrer-status-module branch May 12, 2020 16:14
@jakubgs jakubgs reopened this May 12, 2020
Pipeline for QA automation moved this from DONE to CONTRIBUTOR May 12, 2020
@Ferossgp
Copy link
Contributor

Ferossgp commented May 19, 2020

@flexsurfer will this PR handle also if the referral comes with an Universal Link (join.status.im/0x000...?invite=f79989f679386be7aa56dc1c4&cid=foo) or only if it is from play store?
The params support was added here:
status-im/universal-links-handler#31

@flexsurfer
Copy link
Member Author

this PR only implements android InstallReferrer, im not sure if we still should have it as separate PR, I'm out of context and doesn't work on it anymore

@hesterbruikman
Copy link
Contributor

@flexsurfer @Ferossgp I think only Play Store makes sense. If we reward only for new invites that install the app and purchase Stickerpack, the referral is irrelevant if it doesn't come from the Play Store as it implies the user already had the app installed

@oskarth
Copy link
Contributor

oskarth commented Jul 1, 2020

Small request - could you please rebase to latest master so this commit b5fda12 gets included? This means we aren't running E2E tests on eth.prod cluster anymore, and since this happens on every push, the impact is quite big. This ensures we have more accurate metrics going forward from Jul 1 onward, which would be awesome. See https://discuss.status.im/t/user-growth-and-retention/1782 for more

@flexsurfer
Copy link
Member Author

@Ferossgp is this PR still useful at some point? if so feel free to reopen

@flexsurfer flexsurfer closed this Jul 1, 2020
Pipeline for QA automation moved this from CONTRIBUTOR to DONE Jul 1, 2020
@jakubgs jakubgs deleted the feature/install-referrer-status-module branch September 21, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants