-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] install referrer #10139
[wip] install referrer #10139
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (30)
|
66b563b
to
ecb5041
Compare
11675d9
to
4260b0c
Compare
@jakubgs why? |
Because I asked like 3 times in |
Ah right, because I refreshed the list which added to it these:
This is the script I used: https://github.com/status-im/infra-utils/blob/master/github/list_old_branches.sh |
@flexsurfer will this PR handle also if the referral comes with an Universal Link (join.status.im/0x000...?invite=f79989f679386be7aa56dc1c4&cid=foo) or only if it is from play store? |
this PR only implements android InstallReferrer, im not sure if we still should have it as separate PR, I'm out of context and doesn't work on it anymore |
@flexsurfer @Ferossgp I think only Play Store makes sense. If we reward only for new invites that install the app and purchase Stickerpack, the referral is irrelevant if it doesn't come from the Play Store as it implies the user already had the app installed |
Small request - could you please rebase to latest master so this commit b5fda12 gets included? This means we aren't running E2E tests on eth.prod cluster anymore, and since this happens on every push, the impact is quite big. This ensures we have more accurate metrics going forward from Jul 1 onward, which would be awesome. See https://discuss.status.im/t/user-growth-and-retention/1782 for more |
@Ferossgp is this PR still useful at some point? if so feel free to reopen |
wip