Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 NFT Support via OpenSea #12485

Merged
merged 1 commit into from
Sep 13, 2021
Merged

🎨 NFT Support via OpenSea #12485

merged 1 commit into from
Sep 13, 2021

Conversation

shivekkhurana
Copy link
Contributor

@shivekkhurana shivekkhurana commented Aug 24, 2021 •
edited

fixes #12435

Summary

NFTs are coming to a Status Wallet near you 🥁 🥁 🥁 . This PR adds the ability to see NFTs under the wallet collectibles section. Clicking on an NFT reveals its traits and links to OpenSea.

Missing features:

  • Setting up NFTs as PFPs
  • Transferring NFTs
  • Sharing NFT links via OS share dialog
  • Privacy opt-in similar to link unfurling

Testing notes

  • Try all variations of creating addresses and make sure that NFTs are loaded.
  • Pull to refresh should re-fetch NFTs

Platforms

  • Android
  • iOS

Areas that maybe impacted

  • Wallet
Functional
  • wallet / transactions

status: ready

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Aug 24, 2021
@status-im-auto
Copy link
Member

status-im-auto commented Aug 24, 2021 •
edited

Jenkins Builds

Click to see older builds (27)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ f08783b #1 2021-08-24 11:38:17 ~30 sec android 📄log
❌ f08783b #1 2021-08-24 11:38:18 ~31 sec android-e2e 📄log
❌ f08783b #1 2021-08-24 11:38:21 ~34 sec ios 📄log
✔️ 2c022c7 #2 2021-08-26 08:04:26 ~14 min android-e2e 📦apk 📲
✔️ 2c022c7 #2 2021-08-26 08:04:31 ~14 min android 📦apk 📲
✔️ 2c022c7 #2 2021-08-26 08:07:57 ~18 min ios 📦ipa 📲
❌ 1f2c6f1 #3 2021-08-31 07:36:31 ~26 sec android-e2e 📄log
❌ 1f2c6f1 #3 2021-08-31 07:36:31 ~26 sec android 📄log
❌ 1f2c6f1 #3 2021-08-31 07:36:31 ~26 sec ios 📄log
❌ b9b3dd0 #4 2021-09-01 13:13:20 ~21 sec ios 📄log
❌ b9b3dd0 #4 2021-09-01 13:13:20 ~21 sec android 📄log
❌ b9b3dd0 #4 2021-09-01 13:13:26 ~28 sec android-e2e 📄log
✖️ 80059cd #5 2021-09-06 07:18:57 ~14 min android-e2e 📦apk 📲
✖️ 80059cd #5 2021-09-06 07:18:58 ~14 min android 📦apk 📲
✖️ 80059cd #5 2021-09-06 07:25:51 ~21 min ios 📦ipa 📲
✖️ d0eaaa3 #6 2021-09-06 07:23:57 ~15 min ios 📦ipa 📲
✖️ d0eaaa3 #6 2021-09-06 07:25:17 ~16 min android-e2e 📦apk 📲
✖️ d0eaaa3 #6 2021-09-06 07:25:22 ~16 min android 📦apk 📲
✔️ f9dd619 #8 2021-09-07 03:15:43 ~10 min android-e2e 📦apk 📲
✔️ f9dd619 #8 2021-09-07 03:18:30 ~13 min ios 📦ipa 📲
✔️ f9dd619 #9 2021-09-07 04:14:58 ~13 min android 📦apk 📲
✔️ 433f3ff #7 2021-09-07 03:17:44 ~17 min android-e2e 📦apk 📲
✔️ 433f3ff #7 2021-09-07 03:17:45 ~17 min android 📦apk 📲
✔️ 433f3ff #7 2021-09-07 03:23:10 ~23 min ios 📦ipa 📲
✔️ 32b518d #10 2021-09-07 04:13:56 ~10 min android 📦apk 📲
✔️ 32b518d #9 2021-09-07 04:16:38 ~13 min android-e2e 📦apk 📲
✔️ 32b518d #9 2021-09-07 04:25:06 ~21 min ios 📦ipa 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f44090c #10 2021-09-09 09:45:21 ~10 min android-e2e 📦apk 📲
✔️ f44090c #11 2021-09-09 09:48:57 ~14 min android 📦apk 📲
✔️ f44090c #10 2021-09-09 09:57:13 ~22 min ios 📦ipa 📲
✖️ aafa94b #12 2021-09-13 08:52:34 ~15 min android 📦apk 📲
✖️ aafa94b #11 2021-09-13 08:53:47 ~16 min android-e2e 📦apk 📲
✖️ aafa94b #11 2021-09-13 08:57:02 ~19 min ios 📦ipa 📲

@status-github-bot status-github-bot bot moved this from REVIEW to CONTRIBUTOR in Pipeline for QA Aug 24, 2021
@shivekkhurana shivekkhurana marked this pull request as ready for review August 31, 2021 07:41
flexsurfer
flexsurfer reviewed Sep 2, 2021
View reviewed changes
Copy link
Member

@flexsurfer flexsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general comment, is better to remove opensea from names, and use collectibles , instead of collections

src/status_im/ethereum/json_rpc.cljs Show resolved Hide resolved
src/status_im/multiaccounts/login/core.cljs Outdated Show resolved Hide resolved
src/status_im/multiaccounts/update/core.cljs Show resolved Hide resolved
src/status_im/subs.cljs Outdated Show resolved Hide resolved
src/status_im/ui/screens/home/views.cljs Outdated Show resolved Hide resolved
flexsurfer
flexsurfer reviewed Sep 2, 2021
View reviewed changes
Copy link
Member

@flexsurfer flexsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also can see new colors, are these new colors, should we add them to our colors ns?

src/status_im/ui/components/accordion.cljs Outdated Show resolved Hide resolved
@shivekkhurana
Copy link
Contributor Author

also can see new colors, are these new colors, should we add them to our colors ns?

I'm gonna remove the hex colors. They are already present in colors namespaces.

@shivekkhurana shivekkhurana force-pushed the feature/12435/erc-721 branch 2 times, most recently from f9dd619 to 32b518d Compare September 7, 2021 04:03
@status-im-auto
Copy link
Member

87% of end-end tests have passed

Total executed tests: 69
Failed tests: 9
Passed tests: 60

IDs of failed tests: 6272,6228,5309,6240,6237,6244,5758,5346,5381

Failed tests (9)

Click to expand
  • Rerun tests

    • 1. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272

    Device 1: *Tap on found ReceiveTransactionButton*
    Device 1: *Find Text by accessibility id:* `address-text`

    Device 1: Text by accessibility id: `address-text` is not found on the screen

    Device sessions

    2. test_mobile_data_usage_complex_settings, id: 6228

    Device 1: *Find Button by xpath:* `//*[@text="Use mobile data"]/following-sibling::android.widget.Switch[1]`
    Device 1: *Find Button by xpath:* `//*[@text="Ask me when on mobile network"]/following-sibling::android.widget.Switch[1]`

    Chat history was not fetched with mobile data fetching ON

    Device sessions

    3. test_request_stt_from_daap, id: 5309

    Device 1: *Find AccessKeyButton by xpath:* `//*[@text="Access existing keys"]`
    Device 1: *Find AccessKeyButton by xpath:* `//*[@text="Access existing keys"]`

    Device 1: AccessKeyButton by xpath:* `//*[@text="Access existing keys"]` is not found on the screen

    Device sessions

    4. test_restore_account_from_mnemonic_to_keycard, id: 6240

    Device 1: =========================================================================
    Device 1: **Sign in (password:qwerty, keycard:True)**

    Device 1: SilentButton by accessibility id:`numpad-button-1` is not found on the screen; also Unexpected Alert is shown: 'Cannot read property 'toLowerCase' of null'

    Device sessions

    5. test_fetching_balance_after_offline, id: 6237

    Device 1: =========================================================================
    Device 1: **Toggling airplane mode**

    Cannot perform TouchMove action at (50, 300)

    Device sessions

    6. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244

    Device 1: *Getting ETH amount*
    Device 1: *Scrolling down to SilentButton*

    Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':ETH-asset-value']//android.widget.TextView[1]` is not found on the screen; also Unexpected Alert is shown: 'Cannot read property 'toLowerCase' of null'

    Device sessions

    7. test_keycard_can_recover_keycard_account_card_pairing, id: 5758

    Device 1: =========================================================================
    Device 1: **Sign in (password:qwerty, keycard:True)**

    Device 1: SilentButton by accessibility id:`numpad-button-1` is not found on the screen; also Unexpected Alert is shown: 'Cannot read property 'toLowerCase' of null'

    Device sessions

    8. test_collectible_from_wallet, id: 5346

    Device 1: Check collectibles amount in wallet
    Device 1: =========================================================================

    Device 1: Text by xpath:`//*[@text='CryptoKitties']//following-sibling::android.widget.TextView` is not found on the screen

    Device sessions

    9. test_user_can_see_all_own_assets_after_account_recovering, id: 5381

    Device 1: *Find Button by xpath:* `//*[@text="Collectibles"]`
    Device 1: *Tap on found Button*

    Device 1: User collectibles token name in not shown

    Device sessions

    Passed tests (60)

    Click to expand

    1. test_send_token_with_7_decimals, id: 5350
    Device sessions

    2. test_keycard_create_login_restore_unlock_same_seed, id: 5689
    Device sessions

    3. test_keycard_send_eth_from_wallet_to_address, id: 6289
    Device sessions

    4. test_install_pack_and_send_sticker, id: 5782
    Device sessions

    5. test_send_audio_message_with_push_notification_check, id: 6316
    Device sessions

    6. test_open_chat_by_pasting_chat_key_check_invalid_chat_key_cases, id: 5304
    Device sessions

    7. test_long_press_to_delete_chat, id: 5319
    Device sessions

    8. test_restore_account_migrate_multiaccount_to_keycard, id: 6645
    Device sessions

    9. test_push_notification_1_1_chat_no_pn_activity_center, id: 6283
    Device sessions

    10. test_send_and_open_links_with_previews, id: 5373
    Device sessions

    11. test_manage_assets, id: 5341
    Device sessions

    12. test_open_public_chat_using_deep_link, id: 5396
    Device sessions

    13. test_public_chat_messaging_emojis_timestamps, id: 5313
    Device sessions

    14. test_send_transaction_set_recipient_options, id: 6328
    Device sessions

    15. test_unread_messages_counter_public_chat, id: 5360
    Device sessions

    16. test_logcat_backup_recovery_phrase, id: 5419
    Device sessions

    17. test_keycard_send_eth_in_1_1_chat, id: 6293
    Device sessions

    18. test_keycard_request_stt_from_daap, id: 6249
    Device sessions

    19. test_edit_delete_message_in_one_to_one_and_public_chats, id: 695843
    Device sessions

    20. test_browser_managing_bookmarks, id: 6633
    Device sessions

    21. test_open_blocked_secure_not_secure_inlalid_offline_urls, id: 6210
    Device sessions

    22. test_add_account_to_multiaccount_instance_generate_new, id: 6224
    Device sessions

    23. test_send_eth_to_ens_in_chat, id: 6279
    Device sessions

    24. test_send_eth_from_wallet_to_address_incorrect_password, id: 5308
    Device sessions

    25. test_ens_mentions_pn_and_nickname_in_public_and_1_1_chats, id: 6226
    Device sessions

    26. test_can_use_purchased_stickers_on_recovered_account, id: 5783
    Device sessions

    27. test_dapps_permissions, id: 5738
    Device sessions

    28. test_start_chat_with_ens_mention_in_one_to_one, id: 5403
    Device sessions

    29. test_send_non_english_message_to_newly_added_contact_on_different_networks, id: 5315
    Device sessions

    30. test_keycard_can_see_all_transactions_in_history, id: 6291
    Device sessions

    31. test_sign_message_and_2tx_in_batch_and_transactions_filters_from_daap, id: 5342
    Device sessions

    32. test_send_eth_in_1_1_chat_transaction_push, id: 6253
    Device sessions

    33. test_offline_is_shown_messaging_1_1_chat_sent_delivered, id: 5310
    Device sessions

    34. test_delete_close_all_tabs, id: 5390
    Device sessions

    35. test_redirect_to_public_chat_tapping_tag_message_fetch_more_history, id: 5675
    Device sessions

    36. test_request_and_receive_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    37. test_block_user_from_public_chat, id: 5786
    Device sessions

    38. test_keycard_sign_message_and_transactions_from_daap, id: 6251
    Device sessions

    39. test_can_see_balance_and_all_transactions_history_on_cellular, id: 5314
    Device sessions

    40. test_image_in_one_to_one_send_save_reply_timeline, id: 6305
    Device sessions

    41. test_pair_devices_sync_one_to_one_contacts_nicknames_public_chat, id: 5762
    Device sessions

    42. test_home_view, id: 5379
    Device sessions

    43. test_create_new_group_chat_messaging_pn_delivered, id: 3994
    Device sessions

    44. test_reactions_to_message_in_chats, id: 6315
    Device sessions

    45. test_set_profile_picture, id: 6646
    Device sessions

    46. test_share_copy_contact_code_and_wallet_address, id: 5323
    Device sessions

    47. test_delete_chats_via_delete_button_rejoin, id: 5387
    Device sessions

    48. test_can_add_existing_ens, id: 5502
    Device sessions

    49. test_send_transaction_with_custom_token, id: 6208
    Device sessions

    50. test_offline_add_new_group_chat_member, id: 3998
    Device sessions

    51. test_copy_and_paste_messages, id: 5317
    Device sessions

    52. test_account_recovery_with_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 5394
    Device sessions

    53. test_pass_phrase_validation, id: 5363
    Device sessions

    54. test_insufficient_funds_wallet_positive_balance, id: 5412
    Device sessions

    55. test_open_transaction_on_etherscan_copy_tx_hash, id: 5384
    Device sessions

    56. test_wallet_set_up, id: 5335
    Device sessions

    57. test_switch_users_special_char_password_and_add_new_account_logcat, id: 5356
    Device sessions

    58. test_add_and_remove_mention_contact_with_nickname_from_public_chat, id: 5332
    Device sessions

    59. test_decline_transactions_in_1_1_chat_push_notification_changing_state, id: 6265
    Device sessions

    60. test_recover_account_from_new_user_seedphrase, id: 6296
    Device sessions

    @status-im-auto
    Copy link
    Member

    33% of end-end tests have passed

    Total executed tests: 9
Failed tests: 6
Passed tests: 3

    IDs of failed tests: 6240,6237,6244,5758,5346,5381

    Failed tests (6)

    Click to expand
  • Rerun tests

    • 1. test_restore_account_from_mnemonic_to_keycard, id: 6240

    Device 1: =========================================================================
    Device 1: **Sign in (password:qwerty, keycard:True)**

    Device 1: SilentButton by accessibility id:`numpad-button-1` is not found on the screen; also Unexpected Alert is shown: 'Cannot read property 'toLowerCase' of null'

    Device sessions

    2. test_fetching_balance_after_offline, id: 6237

    Device 1: =========================================================================
    Device 1: **Toggling airplane mode**

    Cannot perform TouchMove action at (50, 300)

    Device sessions

    3. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244

    Device 1: *Getting ETH amount*
    Device 1: *Scrolling down to SilentButton*

    Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':ETH-asset-value']//android.widget.TextView[1]` is not found on the screen; also Unexpected Alert is shown: 'Cannot read property 'toLowerCase' of null'

    Device sessions

    4. test_keycard_can_recover_keycard_account_card_pairing, id: 5758

    Device 1: =========================================================================
    Device 1: **Sign in (password:qwerty, keycard:True)**

    Device 1: SilentButton by accessibility id:`numpad-button-1` is not found on the screen; also Unexpected Alert is shown: 'Cannot read property 'toLowerCase' of null'

    Device sessions

    5. test_collectible_from_wallet, id: 5346

    Device 1: Check collectibles amount in wallet
    Device 1: =========================================================================

    Device 1: Text by xpath:`//*[@text='CryptoKitties']//following-sibling::android.widget.TextView` is not found on the screen

    Device sessions

    6. test_user_can_see_all_own_assets_after_account_recovering, id: 5381

    Device 1: *Find Button by xpath:* `//*[@text="Collectibles"]`
    Device 1: *Tap on found Button*

    Device 1: User collectibles token name in not shown

    Device sessions

    Passed tests (3)

    Click to expand

    1. test_add_account_to_wallet_private_key_and_seed_phrase, id: 6272
    Device sessions

    2. test_mobile_data_usage_complex_settings, id: 6228
    Device sessions

    3. test_request_stt_from_daap, id: 5309
    Device sessions

    @status-im-auto
    Copy link
    Member

    17% of end-end tests have passed

    Total executed tests: 6
Failed tests: 5
Passed tests: 1

    IDs of failed tests: 6240,6244,5758,5346,5381

    Failed tests (5)

    Click to expand
  • Rerun tests

    • 1. test_restore_account_from_mnemonic_to_keycard, id: 6240

    Device 1: =========================================================================
    Device 1: **Sign in (password:qwerty, keycard:True)**

    Device 1: SilentButton by accessibility id:`numpad-button-1` is not found on the screen; also Unexpected Alert is shown: 'Cannot read property 'toLowerCase' of null'

    Device sessions

    2. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244

    Device 1: *Getting ETH amount*
    Device 1: *Scrolling down to SilentButton*

    Device 1: SilentButton by xpath:* `//android.view.ViewGroup[@content-desc=':ETH-asset-value']//android.widget.TextView[1]` is not found on the screen; also Unexpected Alert is shown: 'Cannot read property 'toLowerCase' of null'

    Device sessions

    3. test_keycard_can_recover_keycard_account_card_pairing, id: 5758

    Device 1: =========================================================================
    Device 1: **Sign in (password:qwerty, keycard:True)**

    Device 1: SilentButton by accessibility id:`numpad-button-1` is not found on the screen; also Unexpected Alert is shown: 'Cannot read property 'toLowerCase' of null'

    Device sessions

    4. test_collectible_from_wallet, id: 5346

    Device 1: Check collectibles amount in wallet
    Device 1: =========================================================================

    Device 1: Text by xpath:`//*[@text='CryptoKitties']//following-sibling::android.widget.TextView` is not found on the screen

    Device sessions

    5. test_user_can_see_all_own_assets_after_account_recovering, id: 5381

    Device 1: *Find Button by xpath:* `//*[@text="Collectibles"]`
    Device 1: *Tap on found Button*

    Device 1: User collectibles token name in not shown

    Device sessions

    Passed tests (1)

    Click to expand

    1. test_fetching_balance_after_offline, id: 6237
    Device sessions

    @churik
    Copy link
    Member

    churik commented Sep 7, 2021

    @shivekkhurana
    thank you for PR!
    I couldn't reproduce it on real devices, but it is constantly reproducible on e2e test while relogin with keycard or confirm account deletion in multiaccount.
    Example of failed e2e
    logcat.log

    image

    9-07 10:53:01.864  5721  5815 I ReactNativeJS: NAME: "TypeError"
09-07 10:53:01.864  5721  5815 I ReactNativeJS: MESSAGE: Cannot read property 'toLowerCase' of null
09-07 10:53:01.864  5721  5815 I ReactNativeJS: 
09-07 10:53:01.864  5721  5815 I ReactNativeJS: TypeError: Cannot read property 'toLowerCase' of null
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at Qs (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:70735)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at enn (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:1382707)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at anonymous (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:99471)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at uw (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:83600)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at kw (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:86528)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at anonymous (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:2559627)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at n (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:15627)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at anonymous (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:1763286)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at call (native)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at _w (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:88045)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at anonymous (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:2559855)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at uw (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:83600)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at kw (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:86528)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at anonymous (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:2559905)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at Nr (/build/android/app/build/generated/assets/react/pr/index.android.bundle:142:51194)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at Cr (/build/android/app/build/generated/assets/react/pr/index.android.bundle:142:50985)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at di (/build/android/app/build/generated/assets/react/pr/index.android.bundle:142:83045)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at dl (/build/android/app/build/generated/assets/react/pr/index.android.bundle:142:76332)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at cl (/build/android/app/build/generated/assets/react/pr/index.android.bundle:142:76231)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at sl (/build/android/app/build/generated/assets/react/pr/index.android.bundle:142:75998)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at rl (/build/android/app/build/generated/assets/react/pr/index.android.bundle:142:73131)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at anonymous (/build/android/app/build/generated/assets/react/pr/index.android.bundle:142:24596)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at anonymous (/build/android/app/build/generated/assets/react/pr/index.android.bundle:208:3883)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at Lt (/build/android/app/build/generated/assets/react/pr/index.android.bundle:142:24184)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at Bt (/build/android/app/build/generated/assets/react/pr/index.android.bundle:142:24543)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at Wt (/build/android/app/build/generated/assets/react/pr/index.android.bundle:142:24478)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at Ji (/build/android/app/build/generated/assets/react/pr/index.android.bundle:142:69788)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at enqueueForceUpdate (/build/android/app/build/generated/assets/react/pr/index.android.bundle:142:29795)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at anonymous (/build/android/app/build/generated/assets/react/pr/index.android.bundle:32:1904)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at Zf (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:83040)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at l (/build/android/app/build/generated/assets/react/pr/index.android.bundle:7:82798)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at apply (native)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at anonymous (/build/android/app/build/generated/assets/react/pr/index.android.bundle:158:1255)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at k (/build/android/app/build/generated/assets/react/pr/index.android.bundle:158:543)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at callTimers (/build/android/app/build/generated/assets/react/pr/index.android.bundle:158:2598)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at apply (native)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at value (/build/android/app/build/generated/assets/react/pr/index.android.bundle:77:3328)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at anonymous (/build/android/app/build/generated/assets/react/pr/index.android.bundle:77:663)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at value (/build/android/app/build/generated/assets/react/pr/index.android.bundle:77:2532)
09-07 10:53:01.864  5721  5815 I ReactNativeJS:     at value (/build/android/app/build/generated/assets/react/pr/index.android.bundle:77:635)
09-07 10:53:01.864  5721  5815 I ReactNativeJS: 
09-07 10:53:01.864  5721  5815 I ReactNativeJS: ***
09-07 10:53:01.866  3036  6907 I MediaProvider: End Intent { act=android.intent.action.MEDIA_SCANNER_SCAN_FILE dat=file:///data/local/tmp/screen.png flg=0x1400010 cmp=com.android.providers.media/.MediaService }

    @churik churik moved this from CONTRIBUTOR to TO TEST in Pipeline for QA Sep 9, 2021
    @churik churik moved this from TO TEST to IN TESTING in Pipeline for QA Sep 9, 2021
    @status-im-auto
    Copy link
    Member

    60% of end-end tests have passed

    Total executed tests: 5
Failed tests: 2
Passed tests: 3

    IDs of failed tests: 5346,5381

    Failed tests (2)

    Click to expand
  • Rerun tests

    • 1. test_collectible_from_wallet, id: 5346

    Device 1: Check collectibles amount in wallet
    Device 1: =========================================================================

    Device 1: Text by xpath:`//*[@text='CryptoKitties']//following-sibling::android.widget.TextView` is not found on the screen

    Device sessions

    2. test_user_can_see_all_own_assets_after_account_recovering, id: 5381

    Device 1: *Find Button by xpath:* `//*[@text="Collectibles"]`
    Device 1: *Tap on found Button*

    Device 1: User collectibles token name in not shown

    Device sessions

    Passed tests (3)

    Click to expand

    1. test_restore_account_from_mnemonic_to_keycard, id: 6240
    Device sessions

    2. test_add_and_delete_watch_only_account_to_multiaccount_instance, id: 6244
    Device sessions

    3. test_keycard_can_recover_keycard_account_card_pairing, id: 5758
    Device sessions

    @churik
    Copy link
    Member

    churik commented Sep 9, 2021

    PrR tested only for regression (feature itself is not tested thoroughly, as it will be enabled and reworked a bit)
    Don't see regression issues anymore for now, ready to be merged

    @churik churik moved this from IN TESTING to MERGE in Pipeline for QA Sep 9, 2021
    @shivekkhurana
    🎨 NFT Support via OpenSea
    e2ddf75 
    Baic skeleton 🦴
NFT Details page. The API is not returning properties
Add traits, add opensea link, fetch nfts when new account is added
Toggle privacy options
Hide NFT behind FF
Update sgv
Fix lint and rename opensea to collectibles

Signed-off-by: Shivek Khurana <shivek@status.im>
    @shivekkhurana shivekkhurana merged commit e2ddf75 into develop Sep 13, 2021
    Pipeline for QA automation moved this from MERGE to DONE Sep 13, 2021
    @shivekkhurana shivekkhurana deleted the feature/12435/erc-721 branch September 13, 2021 08:44
    @churik churik mentioned this pull request Sep 22, 2021
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer left review comments

    @rasom rasom rasom approved these changes

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    @jakubgs jakubgs Awaiting requested review from jakubgs jakubgs is a code owner

    Assignees

    @shivekkhurana shivekkhurana

    Labels
    None yet
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Add support for EIP-721 collectibles
    5 participants
    @shivekkhurana @status-im-auto @churik @rasom @flexsurfer