-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 NFT Support via OpenSea #12485
🎨 NFT Support via OpenSea #12485
Conversation
Jenkins BuildsClick to see older builds (27)
|
f08783b
to
2c022c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general comment, is better to remove opensea from names, and use collectibles , instead of collections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also can see new colors, are these new colors, should we add them to our colors ns?
I'm gonna remove the hex colors. They are already present in colors namespaces. |
b9b3dd0
to
80059cd
Compare
f9dd619
to
32b518d
Compare
87% of end-end tests have passed
Failed tests (9)Click to expand
Passed tests (60)Click to expand |
33% of end-end tests have passed
Failed tests (6)Click to expand
Passed tests (3)Click to expand
|
17% of end-end tests have passed
Failed tests (5)Click to expand
Passed tests (1) |
@shivekkhurana
|
32b518d
to
f44090c
Compare
60% of end-end tests have passed
Failed tests (2)Click to expand
Passed tests (3)Click to expand
|
PrR tested only for regression (feature itself is not tested thoroughly, as it will be enabled and reworked a bit) |
f44090c
to
aafa94b
Compare
Baic skeleton 🦴 NFT Details page. The API is not returning properties Add traits, add opensea link, fetch nfts when new account is added Toggle privacy options Hide NFT behind FF Update sgv Fix lint and rename opensea to collectibles Signed-off-by: Shivek Khurana <shivek@status.im>
aafa94b
to
e2ddf75
Compare
fixes #12435
Summary
NFTs are coming to a Status Wallet near you 🥁 🥁 🥁 . This PR adds the ability to see NFTs under the wallet collectibles section. Clicking on an NFT reveals its traits and links to OpenSea.
Missing features:
Testing notes
Platforms
Areas that maybe impacted
Functional
status: ready