Avatars/dApp Avatar Component #20145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajayesivan
requested review from
vkjr,
qfrank,
briansztamfater,
BalogunofAfrica and
ulisesmac
Jenkins BuildsClick to see older builds (17)
|
J-Son89
approved these changes
May 22, 2024
BalogunofAfrica
approved these changes
May 22, 2024
ajayesivan
force-pushed
the
20129-dapp-avatar-component
branch
from
80b8b48
to
9ae8bd1
Compare
briansztamfater
approved these changes
May 22, 2024
| {:style (merge style/container container-style) | ||
| :accessibility-label :dapp-avatar} | ||
| [hole-view/hole-view | ||
| {:key (hash context?) |
There was a problem hiding this comment.
Same as here #20141 (comment), wdyt?
There was a problem hiding this comment.
@ajayesivan isn't it enough if we only provide context? or maybe booleans arent a valid react key?
There was a problem hiding this comment.
@briansztamfater Changed the code to only add key prop for Android
There was a problem hiding this comment.
@ulisesmac Yes we can use boolean value for :key. I have updated the code.
ulisesmac
approved these changes
May 22, 2024
vkjr
approved these changes
May 23, 2024
ajayesivan
force-pushed
the
20129-dapp-avatar-component
branch
from
9ae8bd1
to
6ce9d4d
Compare
87% of end-end tests have passedFailed tests (4)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestWalletOneDevice:
Class TestWalletMultipleDevice:
Expected to fail tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (45)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestDeepLinksOneDevice:
|
ajayesivan
force-pushed
the
20129-dapp-avatar-component
branch
2 times, most recently
from
b868b33
to
6defa2c
Compare
|
Hi @Francesca-G, could you please do a design review for this PR? Thanks! |
ajayesivan
force-pushed
the
20129-dapp-avatar-component
branch
from
6defa2c
to
a17799a
Compare
J-Son89
added a commit
that referenced
this pull request
May 24, 2024
Fix hidden hook usage Improve logging for unsupported collectibles Fix re-rendering of collectibles in flat-list chore: clean up implementation and speed up animation remove apply animations to style chore: use default opacity chore: use default opacity chore: add issue to todo chore: use flex chore: flex Avatars/Community Avatar Component (#20147) Avatars/dApp Avatar Component (#20145) Update eth-archival pokt url Remove not implemented Notification settings from community longtap m… (#20169) pick between JSC & Hermes for Android (#20171) We implement both `JSC` and `Hermes` in build phase of `Android` which increases our `APK` size by ~ `2 MB`. This was fine before but currently we have to get below the `100 MB` limit. This commit implements the preferred engine after inferring `hermesEnabled` property from gradle.properties This property is modified at build time for release here https://github.com/status-im/status-mobile/blob/178d62bd276afffef5fe7a3f773e390d83336d9c/nix/mobile/android/build.nix#L17 and set for debug here https://github.com/status-im/status-mobile/blob/178d62bd276afffef5fe7a3f773e390d83336d9c/Makefile#L280 Which should further reduce the `APK` size by `2 MB`. [#19232] - Fix derivation path generation and keypair creation (#19531) * Add more default dependencies to slide button * Fix wallet account creation: derivation paths and keypairs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20129
Summary
Implements the Avatars/dApp-Avatar component
Testing notes
Manual QA can be skipped since this PR only adds a quo component and doesn't introduce any changes outside Quo Preview.
Platforms
Areas that maybe impacted
None
Steps to test
Quo Preview -> Avatars -> dApp Avatar
status: ready