Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No ability to create additional ETH account after removal #19232

Closed
Tracked by #19090
VolodLytvynenko opened this issue Mar 13, 2024 · 3 comments · Fixed by #19531
Closed
Tracked by #19090

No ability to create additional ETH account after removal #19232

VolodLytvynenko opened this issue Mar 13, 2024 · 3 comments · Fixed by #19531
Assignees
@ulisesmac
Labels
high-prio
Milestone
2.30.0 Beta

Comments

@VolodLytvynenko
Copy link
Contributor

Steps:

  1. Go to the wallet and create an additional ETH account (e.g., "test account 2"). (The current account is created with Derivation path m/44/60/0/0/1 for this account).
  2. Create one more ETH account (e.g., "test account 3").
  3. Remove "test account 2".
  4. Go to the account creation flow.
  5. Check the Derivation path on the color picker screen during ETH account creation (The current account is created with Derivation path m/44/60/0/0/2 instead of m/44/60/0/0/1).
  6. Try to finish the account creation.

Actual Result:

  • The Derivation path for the new account is incorrect.
  • The account is not created after confirming the slide to create account button.
der_path.mp4

Expected Result:

  • The Derivation path for the newly created account should be the same as it was when the account was removed.
  • The account should be created successfully.

Logs:

Status-debug-logs.zip
@VolodLytvynenko VolodLytvynenko added this to the 2.28.0 Alpha milestone Mar 13, 2024
@VolodLytvynenko VolodLytvynenko mentioned this issue Mar 13, 2024
Closed
21 tasks
@cammellos cammellos removed this from the 2.28.0 Alpha milestone Mar 14, 2024
@ulisesmac ulisesmac self-assigned this Mar 19, 2024
This was referenced Apr 4, 2024
Merged
Merged
@churik churik added this to the 2.29.0 Alpha milestone Apr 5, 2024
@J-Son89
Copy link
Contributor

J-Son89 commented Apr 8, 2024

@ulisesmac - is this issue still relevant?

@VolodLytvynenko
Copy link
Contributor Author

@ulisesmac - is this issue still relevant?

@J-Son89 the issue still exists

@ulisesmac
Copy link
Contributor

@VolodLytvynenko @J-Son89

Yeah, this is still reproducible, I've opened a PR for it:

@churik churik modified the milestones: 2.29.0 Alpha, 2.30.0 Alpha May 3, 2024
ulisesmac added a commit that referenced this issue May 24, 2024
@ulisesmac
[#19232] - Fix derivation path generation and keypair creation (#19531)
49a41f4 
* Add more default dependencies to slide button

* Fix wallet account creation: derivation paths and keypairs
J-Son89 added a commit that referenced this issue May 24, 2024
@J-Son89
chore: first pass at fixing collectibles transition
bde0a3b 
Fix hidden hook usage

Improve logging for unsupported collectibles

Fix re-rendering of collectibles in flat-list

chore: clean up implementation and speed up animation

remove apply animations to style

chore: use default opacity

chore: use default opacity

chore: add issue to todo

chore: use flex

chore: flex

Avatars/Community Avatar Component (#20147)

Avatars/dApp Avatar Component (#20145)

Update eth-archival pokt url

Remove not implemented Notification settings from community longtap m… (#20169)

pick between JSC & Hermes for Android (#20171)

We implement both `JSC` and `Hermes` in build phase of `Android` which increases our `APK` size by ~ `2 MB`.
This was fine before but currently we have to get below the `100 MB` limit.

This commit implements the preferred engine after inferring `hermesEnabled`  property from gradle.properties
This property is modified at build time for release here
https://github.com/status-im/status-mobile/blob/178d62bd276afffef5fe7a3f773e390d83336d9c/nix/mobile/android/build.nix#L17
and set for debug here
https://github.com/status-im/status-mobile/blob/178d62bd276afffef5fe7a3f773e390d83336d9c/Makefile#L280

Which should further reduce the `APK` size by `2 MB`.

[#19232] - Fix derivation path generation and keypair creation (#19531)

* Add more default dependencies to slide button

* Fix wallet account creation: derivation paths and keypairs
@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulisesmac ulisesmac

Labels
high-prio
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Status: Done
Milestone
2.30.0 Beta
Development

Successfully merging a pull request may close this issue.

[#19232] - Fix derivation path generation status-im/status-mobile
6 participants
@ilmotta @cammellos @churik @J-Son89 @VolodLytvynenko @ulisesmac