Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Korean translations #9083

Merged
merged 1 commit into from Oct 3, 2019
Merged

Update the Korean translations #9083

merged 1 commit into from Oct 3, 2019

Conversation

jinhojang6
Copy link
Member

The ko.json file is updated

@jinhojang6 jinhojang6 requested a review from a team as a code owner October 1, 2019 13:15
@auto-assign auto-assign bot removed the request for review from a team October 1, 2019 13:15
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Oct 1, 2019
@jinhojang6 jinhojang6 self-assigned this Oct 1, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Oct 1, 2019 •
edited

Jenkins Builds

Click to see older builds (6)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 8b9c9bf #1 2019-10-01 13:18:27 ~2 min macos 📄log
❌ 8b9c9bf #1 2019-10-01 13:18:59 ~3 min linux 📄log
❌ 8b9c9bf #1 2019-10-01 13:19:10 ~3 min windows 📄log
✔️ 8b9c9bf #1 2019-10-01 13:25:54 ~10 min ios 📦ipa 📲
✔️ 8b9c9bf #1 2019-10-01 13:28:51 ~13 min android 📦apk 📲
✔️ 8b9c9bf #1 2019-10-01 13:29:47 ~14 min android-e2e 📦apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 67126bb #2 2019-10-03 11:15:46 ~10 min ios 📦ipa 📲
✔️ 67126bb #2 2019-10-03 11:17:55 ~12 min macos 📦dmg
✔️ 67126bb #2 2019-10-03 11:18:54 ~13 min android 📦apk 📲
✔️ 67126bb #2 2019-10-03 11:18:56 ~13 min android-e2e 📦apk 📲
✔️ 67126bb #2 2019-10-03 11:20:23 ~14 min linux 📦App
✔️ 67126bb #2 2019-10-03 11:21:00 ~15 min windows 📦exe
✔️ fb6e693 #3 2019-10-03 11:34:34 ~8 min ios 📦ipa 📲
✔️ fb6e693 #3 2019-10-03 11:37:05 ~10 min android-e2e 📦apk 📲
✔️ fb6e693 #3 2019-10-03 11:37:11 ~10 min android 📦apk 📲
✔️ fb6e693 #3 2019-10-03 11:37:52 ~11 min macos 📦dmg
✔️ fb6e693 #3 2019-10-03 11:40:40 ~14 min windows 📦exe
✔️ fb6e693 #3 2019-10-03 11:40:58 ~14 min linux 📦App

@jinhojang6
Copy link
Member Author

@jakubgs All the desktop builds failed. Is it okay?

@jakubgs
Copy link
Member

jakubgs commented Oct 1, 2019

No worries about that, it's because of 42961f3, which broke the desktop builds.

jakubgs
jakubgs approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what I'm looking at.

@jakubgs
Copy link
Member

jakubgs commented Oct 2, 2019

Please rebase, #8630 was merged, which should fix the desktop failures.

@Serhy Serhy moved this from REVIEW to E2E Tests in Pipeline for QA Oct 3, 2019
@statustestbot
Copy link

96% of end-end tests have passed

Total executed tests: 47
Failed tests: 2
Passed tests: 45

Failed tests (2)

Click to expand
1. test_logcat_send_transaction_from_daap

Device 1: Tap on SignButton
Device 1: Wait for OkButton

Device 1: 'OkButton' is not found on the screen

Device sessions

2. test_offline_messaging_1_1_chat

Device 2: Tap on AirplaneModeButton
Device 1: Tap on AirplaneModeButton

Device 1: 'ConnectionStatusText' is still visible on the screen after 30 seconds

Device sessions

Passed tests (45)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message
Device sessions

13. test_unread_messages_counter_1_1_chat
Device sessions

14. test_ens_in_public_chat
Device sessions

15. test_send_message_in_group_chat
Device sessions

16. test_logcat_send_transaction_from_wallet
Device sessions

17. test_send_token_with_7_decimals
Device sessions

18. test_modify_transaction_fee_values
Device sessions

19. test_send_eth_from_wallet_to_address
Device sessions

20. test_add_account_to_multiaccount_instance
Device sessions

21. test_manage_assets
Device sessions

22. test_long_press_to_delete_public_chat
Device sessions

23. test_send_emoji
Device sessions

24. test_search_chat_on_home
Device sessions

25. test_logcat_recovering_account
Device sessions

26. test_can_add_existing_ens
Device sessions

27. test_messaging_in_different_networks
Device sessions

28. test_logcat_backup_recovery_phrase
Device sessions

29. test_logcat_sign_message_from_daap
Device sessions

30. test_switch_users_and_add_new_account
Device sessions

31. test_send_stt_from_wallet
Device sessions

32. test_login_with_new_account
Device sessions

33. test_start_chat_with_ens
Device sessions

34. test_add_contact_from_public_chat
Device sessions

35. test_send_two_transactions_one_after_another_in_dapp
Device sessions

36. test_password_in_logcat_creating_account
Device sessions

37. test_backup_recovery_phrase
Device sessions

38. test_offline_status
Device sessions

39. test_open_google_com_via_open_dapp
Device sessions

40. test_unread_messages_counter_public_chat
Device sessions

41. test_sign_message_from_daap
Device sessions

42. test_user_can_remove_profile_picture
Device sessions

43. test_share_contact_code_and_wallet_address
Device sessions

44. test_refresh_button_browsing_app_webview
Device sessions

45. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@jinhojang6 jinhojang6 requested a review from a team October 3, 2019 11:05
@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock and mobile/js_files/yarn.lock changed. Pinging @jakubgs, @pombeirp, and @corpetty

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 2
Failed tests: 0
Passed tests: 2

Passed tests (2)

Click to expand
1. test_logcat_send_transaction_from_daap
Device sessions

2. test_offline_messaging_1_1_chat
Device sessions

@Serhy Serhy moved this from E2E Tests to MERGE in Pipeline for QA Oct 3, 2019
@jinhojang6 @jakubgs
update-kr-translations
d2a51f9 
Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs merged commit d2a51f9 into develop Oct 3, 2019
Pipeline for QA automation moved this from MERGE to DONE Oct 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the update-kr-translations branch October 3, 2019 13:35
@weekly-digest weekly-digest bot mentioned this pull request Oct 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedropombeiro pedropombeiro pedropombeiro approved these changes

@jakubgs jakubgs jakubgs approved these changes

@churik churik Awaiting requested review from churik

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

@antdanchenko antdanchenko Awaiting requested review from antdanchenko

@vkjr vkjr Awaiting requested review from vkjr

Assignees

@jinhojang6 jinhojang6

Labels
None yet
Projects
Pipeline for QA
  
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jinhojang6 @status-im-auto @jakubgs @statustestbot @pedropombeiro