0.9.32 mobile release #6891
Comments
|
@chadyj can we fill description of this issue with:
Also, are we going to release next week? If yes, can we cut the release/0.9.32 tomorrow? We have group chats that we should release asap as they will minimize the impact of PFS release in the future.
|
|
@mandrigin any comments for the above? @jeluard Mentioned that this release needs to be out by Sunday Nov 2nd, so lets hustle! @jeluard Is everything in develop and ready to go? What are the Kyber changes needed? |
|
@chadyj Some commits are still missing. Realistically the target date would be Dec 7 |
|
I can be responsible for release testing and coordinating with test team except this Friday (nov 30). @jeluard when missing commits will be ready, so we cut off the branch for testing? Ideally, we'd like to have 1st release build for regression testing tomorrow morning. |
|
@annadanchenko Sounds good! |
|
@chadyj emm, what did you want me to comment on? 😆 |
This comment #6891 (comment) |
|
Well, I can fix some bugs for this release. |
|
@mandrigin can you create 0.9.32 release build, please? Should also have version 0.9.32 in the app |
|
Translation string updates are ready for testing and review #6891 |
|
@annadanchenko done. |
cc @Blockchain-Islander @pablanopete @j-zerah Take a look. If all goes well well we can release Monday or Tuesday. |
|
@corpetty @mandrigin guys, do we need to do anything extra from security pov on the release 0.9.32 built today? like review again dependencies, as #6906 is not done yet. |
|
according to @cammellos we need to cherry pick status-im/status-go#1293 into the release if we want to have group chats in it. If it's a low impact change on status-go side then I'm fine with it. Any opinions on it @adambabik @mandrigin @chadyj ? |
I'd love to see group chats #6882 in the release if this is a low impact change. |
|
Btw, I've been checking average battery consumption in nightlies for the last 20 days and it looks stable. For measurements, I used #6692 with some reference tests like creating new account, sending message, etc. Screenshot of latest results. |
|
Kudos @lukaszfryc for checking battery consumption!!! |
|
Release 0.9.32 builds (https://ci.status.im/job/status-react/job/release/job/release%252F0.9.32/2/) has the #6881 is related and it's fix already in progress: #6894 @jakubgs, @mandrigin we'll need to add it in release/0.9.32 as well in order to have app version with new format. |
Do we have a timeframe on getting #6906 done? I don't have anything else that is incredibly pressing for this release. |
|
I made it work on macOS just fine, on Linux npm behaves weirdly :( fixing that now... |
|
#6894 has been merged into develop. |
|
and #6917 is also ready to be merged and cherry picked @mandrigin |
|
@corpetty @annadanchenko #6906 — let's switch to yarn instead. I'll work on it, but it shouldn't stop the release. We can check the modified package-lock file for release builds separately, if needed. |
|
FYI There's a bunch of extensions related commits that will have to be cherry picked. |
|
having another thought on it - only users with diawi access can install ios builds, so typical user will have TestFlight version anyway so might not be a blocker really, unless it can influence future upgrades |
|
We have the fix merged #7028 so may as well run a new build. |
|
@chadyj we may but I'm not sure if other changes in upload release job are fine and would rather stay with 9999 as exception for this release. Unless developers will say that 9999 in the version can impact future upgrades cc @mandrigin @rasom @cammellos |
|
@j-zerah @Blockchain-Islander @pablanopete Apologies for the delay. There have been some tech issues and we don't have consensus on how to proceed. Hopefully we will have an update within the hour. |
|
@j-zerah @Blockchain-Islander @pablanopete looks like we got consensus and will push the release in 10 minutes from now. |
|
ok thank you. Please let us know when comms can go out |
|
@j-zerah @Blockchain-Islander @pablanopete both iOS and Android releases for 0.9.32 are published. Please, send comms cc @chadyj |
|
Ok, thanks! |
|
Comms are out! Thanks y'all! Seeya next time 🍻
|
|
@pablanopete 0.9.32 apk for cn site: http://status-im.ams3.digitaloceanspaces.com/StatusIm-181206-094952-05782d-release.apk |
|
Re-opening as there are multiple reports of "unknown status-go error" https://twitter.com/carlos_molotov/status/1070711892505698304?s=21
|
|
Shortly after the release we saw reports of an "unknown status-go error" from 3 users upgrading to 0.9.32. After investigating @Serhy could reproduce the issue for account passwords that contained a special character (such as -/:;()$&@“.,?!’[]{}#%^*+=_|~<>€£¥•.,?!’) and it was discovered that passwords may not be escaped properly in some circumstances. @cammellos is working on a hotfix which we are aiming to release within the next hour. |
|
Thanks @cammellos and @Serhy for working on and finding this issue. Can I please suggest we create post-mortem on this, so that we can understand how this slipped through and ensure this kind of error doesn't slip into future releases. The template can be found in this Discuss post: https://discuss.status.im/t/post-mortems-learning-from-our-mistakes/581
|
|
This happened to me and my password does have a special character. I downloaded version 0.9.32 to my iPhone and I was getting pink bubble appearing above my password when I entered it to launch the app and the bubble said, "Unkown Status-go error" So I deleted the app and reloaded it. But now when I enter my Recovery Phrase and Password then hit "Sign In" nothing happens except the Seed Phrase and password entry bubbles are blanked out. I entered my seed phrase multiple times. Now I can't get on status to get help. So that is why I am posting here. That was my experience. Looking forward to the hot fix. Thanks all |
|
Update: A fix to this issue has been made and we are currently building and testing the changes. If all goes well a hotfix will be released in the next 1-2 hours. A post-mortem will also be published. @jbostick00 Thanks for the feedback. Hang tight a fix is on its way. |
|
@mandrigin @jakubgs @rasom We could use some help. The iOS upload job keeps failing. @cammellos Has the fix but we can't publish.
https://ci.status.im/job/status-react/job/upload_release_ios/65/console |
|
Just to add some context, the build is not on DO but it is on github, the link for ios is correct, it either times out or there's some other issue |
It seems like the zip is corrupted, but I downloaded it by hand and it unpacks just fine. |
|
I started a build to upload that again, let's see if that helps: Edit: Just started it with the right branch and |
|
@jakubgs I think it just fails to download it |
|
I can download it locally fine and already an ios build has been successfuly built using that zip file https://ci.status.im/job/status-react/job/release/job/release%252F0.9.32/ https://ci.status.im/job/status-react/job/combined/job/mobile-ios/4877/consoleFull |
|
This one seems to be running just fine: https://ci.status.im/job/status-react/job/upload_release_ios/66/
|
|
yes, it managed to download, thanks |
|
The hot fix has been published. Kudos team for working late to get this sorted. The post-mortem draft has started here https://notes.status.im/U7gkLuCiSly3faDXKzRbmQ @pablanopete Please let us know here if there are any more issues that pop up over night. |
|
Thanks all |
|
Hey @chadyj @annadanchenko @cammellos - both Ben & I are still getting this status-go error. We've just updated to 0.9.32 now. |
|
@rachelhamlin looking into this, pinged you on status with a few questions |
We will use this issue to manage 0.9.32 release.
open issues and PRs for release: https://github.com/status-im/status-react/labels/release
The text was updated successfully, but these errors were encountered: