-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop eth.beta fleet, it's been decommissioned #10051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubgs
requested review from
andremedeiros,
cammellos,
yenda,
rasom,
churik and
flexsurfer
February 17, 2020 16:50
Pull Request Checklist
|
cammellos
approved these changes
Feb 17, 2020
Jenkins BuildsClick to see older builds (6)
|
corpetty
approved these changes
Feb 17, 2020
no objections from QA side |
churik
approved these changes
Feb 18, 2020
96% of end-end tests have passed
Failed tests (4)Click to expand
Passed tests (93)Click to expand |
E2E tests were throwing an error:
So I switched the credential from |
jakubgs
force-pushed
the
drop-beta-fleet
branch
from
February 18, 2020 13:33
28562b9
to
0821cee
Compare
95% of end-end tests have passed
Failed tests (5)Click to expand
Passed tests (92)Click to expand |
jakubgs
force-pushed
the
drop-beta-fleet
branch
from
February 18, 2020 16:37
0821cee
to
15e1655
Compare
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
drop-beta-fleet
branch
from
February 18, 2020 19:50
15e1655
to
8ffbf61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've killed the
eth.beta
fleet because the only remaining peers were ~5 desktop users.