Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to make desktop work by commenting out packages etc. #10411

Closed
wants to merge 8 commits into from
Closed

Try to make desktop work by commenting out packages etc. #10411

wants to merge 8 commits into from
+1,528 −2,527

Conversation

vitvly
Copy link
Member

@vitvly vitvly commented Apr 22, 2020 •
edited by StatusWrike
Loading

Steps required in order to launch this:

  1. Have a working Qt installation. Download Qt online installer (latest version 5.14.2 seems to work fine). Then in your shell:
export QT_PATH=/Users/vvlasov/Qt/5.14.2
export PATH=$QT_PATH/clang_64/bin:$PATH
  1. As Nix is not yet updated, packages have to be installed manually. Inside status-react folder:
ln -sf desktop/js_files/package.json package.json
ln -sf desktop/js_files/yarn.lock yarn.lock
yarn

  1. Build status-go and fetch https://github.com/status-im/qtkeychain.
    status-go can be built by executing make shell and then inside Nix shell nix-build --attr targets.status-go.desktop in refactor/nix-status-go branch.

  2. Then in 4 different shells:

1. react-native start # RN bundler
2. clj -R:dev build.clj watch --platform desktop # Compile CLJS
3. node node_modules/react-native-desktop-qt/js-executor.js # Run Node instance that will execute JS code
4. # export some env vars (temporarily needed until Nix works and populates this for us)
export STATUS_GO_DESKTOP_LIBDIR=<nix_store_status_go build_dir>/lib 
export STATUS_GO_DESKTOP_INCLUDEDIR=<nix_store_status_go build_dir>/include
export QTKEYCHAIN_SOURCES=<dir with status-im/qtkeychain repo>
react-native run-desktop # Run QT app

Note: if you ever had Status Desktop installed, you might have an old set of data files on your filesystem (~/Library/Application Support/Status on macOS). Please delete those as openAccounts call will most likely fail due to incompatible application versions.

@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock and mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 22, 2020
@status-im-auto
Copy link
Member

status-im-auto commented Apr 22, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (12)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 3049261 #1 2020-04-22 14:27:51 ~19 sec android 📄log
❌ 3049261 #1 2020-04-22 14:27:52 ~20 sec android-e2e 📄log
❌ dcb77af #2 2020-04-22 14:33:02 ~12 sec android-e2e 📄log
❌ dcb77af #2 2020-04-22 14:33:11 ~19 sec android 📄log
❌ b9c6321 #3 2020-04-28 09:30:40 ~23 sec android-e2e 📄log
❌ b9c6321 #3 2020-04-28 09:30:42 ~21 sec android 📄log
❌ aaa85df #4 2020-04-28 10:39:20 ~14 sec android-e2e 📄log
❌ aaa85df #4 2020-04-28 10:39:23 ~14 sec android 📄log
❌ 4162aea #5 2020-04-28 10:41:14 ~12 sec android-e2e 📄log
❌ 4162aea #5 2020-04-28 10:41:18 ~13 sec android 📄log
❌ 704929a #6 2020-04-28 12:29:20 ~15 sec android-e2e 📄log
❌ 704929a #6 2020-04-28 12:29:23 ~14 sec android 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ f527801 #7 2020-04-30 20:53:16 ~22 sec android-e2e 📄log
❌ f527801 #7 2020-04-30 20:53:16 ~21 sec android 📄log
❌ 7352f8f #8 2020-04-30 21:26:03 ~21 sec android-e2e 📄log
❌ 7352f8f #8 2020-04-30 21:26:03 ~20 sec android 📄log

@status-github-bot status-github-bot bot moved this from REVIEW to CONTRIBUTOR in Pipeline for QA Apr 22, 2020
@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock and mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

1 similar comment
@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock and mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@weekly-digest weekly-digest bot mentioned this pull request Apr 26, 2020
Closed
@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock and mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock and mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock and mobile/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

1 similar comment
@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

3 similar comments
@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@jakubgs jakubgs mentioned this pull request Apr 30, 2020
Merged
@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@dependency-lockfile-snitch
Copy link

desktop/js_files/yarn.lock changed. Pinging @jakubgs and @corpetty

@weekly-digest weekly-digest bot mentioned this pull request May 3, 2020
Closed
@vitvly vitvly self-assigned this May 27, 2020
@flexsurfer
Copy link
Member

@siphiuel is this still relevant?

@vitvly
Copy link
Member Author

vitvly commented Jun 19, 2020

@flexsurfer no, thanks for highlighting this. Superseded by #10578

@vitvly vitvly closed this Jun 19, 2020
Pipeline for QA automation moved this from CONTRIBUTOR to DONE Jun 19, 2020
@jakubgs jakubgs deleted the feature/desktop-update branch September 21, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs Awaiting requested review from jakubgs jakubgs will be requested when the pull request is marked ready for review jakubgs is a code owner

Assignees

@vitvly vitvly

Labels
None yet
Projects
Pipeline for QA
  
DONE
Pipeline for QA
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitvly @status-im-auto @flexsurfer